Skip to content

Commit

Permalink
[main>2.0] ci: fix build-tools installation in GH actions workflow (#…
Browse files Browse the repository at this point in the history
…21623)

Ports #21556 from main to 2.0.

This workflow was not updated after build-tools was updated to ESM
instead of CJS. The fix is to use `npm link` to make `flub` available
since the old shim was removed when we switched to ESM.

Tested with [act](https://github.com/nektos/act):

```
act push -W .github/workflows/push-tag-create-release.yml -v
```
  • Loading branch information
tylerbutler authored Jun 26, 2024
1 parent 4078c81 commit 704ebde
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/push-tag-create-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@ jobs:
cd build-tools
pnpm install --frozen-lockfile
pnpm run build:compile
# add the bin dir of build-cli to the path
cd packages/build-cli/bin
echo "$(pwd)" >> $GITHUB_PATH
# We want flub available to call, so we run npm link in the build-cli package, which creates shims that are avilable on the PATH
# Use npm link instead of pnpm link because it handles bins better
cd packages/build-cli
npm link
- name: Check build-tools installation
run: |
Expand Down

0 comments on commit 704ebde

Please sign in to comment.