Skip to content

Commit

Permalink
Remove unnecessary/missed common definitions imports and deps (#16281)
Browse files Browse the repository at this point in the history
This is a follow-up to
#16211, removing the dep
`@fluidframework/common-definitions` if its not used in the package and
catch any stray ones I may have missed

The type test infrastructure seems to sometimes output type tests for
re-exported APIs, but not always. Since the type test changes in this PR
are related to that - a re-exported API was tested before and no longer
is - the change should be non-breaking.
  • Loading branch information
RishhiB authored Jul 11, 2023
1 parent a8fbb2e commit 7458e8a
Show file tree
Hide file tree
Showing 102 changed files with 33 additions and 186 deletions.
4 changes: 2 additions & 2 deletions api-report/azure-client.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ import { IConfigProviderBase } from '@fluidframework/telemetry-utils';
import { IFluidContainer } from '@fluidframework/fluid-static';
import { IMember } from '@fluidframework/fluid-static';
import { IServiceAudience } from '@fluidframework/fluid-static';
import { ITelemetryBaseEvent } from '@fluidframework/core-interfaces';
import { ITelemetryBaseLogger } from '@fluidframework/core-interfaces';
import { ITelemetryBaseEvent } from '@fluidframework/common-definitions';
import { ITelemetryBaseLogger } from '@fluidframework/common-definitions';
import { ITokenClaims } from '@fluidframework/protocol-definitions';
import { ITokenProvider } from '@fluidframework/routerlicious-driver';
import { ITokenResponse } from '@fluidframework/routerlicious-driver';
Expand Down
2 changes: 1 addition & 1 deletion api-report/container-definitions.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import { ISnapshotTree } from '@fluidframework/protocol-definitions';
import { ISummaryContent } from '@fluidframework/protocol-definitions';
import { ISummaryTree } from '@fluidframework/protocol-definitions';
import { ITelemetryBaseLogger } from '@fluidframework/core-interfaces';
import { ITelemetryProperties } from '@fluidframework/common-definitions';
import { ITelemetryProperties } from '@fluidframework/core-interfaces';
import { ITokenClaims } from '@fluidframework/protocol-definitions';
import { IVersion } from '@fluidframework/protocol-definitions';
import { MessageType } from '@fluidframework/protocol-definitions';
Expand Down
2 changes: 1 addition & 1 deletion api-report/driver-utils.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import { ISummaryHandle } from '@fluidframework/protocol-definitions';
import { ISummaryTree } from '@fluidframework/protocol-definitions';
import { ITelemetryErrorEvent } from '@fluidframework/core-interfaces';
import { ITelemetryLoggerExt } from '@fluidframework/telemetry-utils';
import { ITelemetryProperties } from '@fluidframework/common-definitions';
import { ITelemetryProperties } from '@fluidframework/core-interfaces';
import { IThrottlingWarning } from '@fluidframework/driver-definitions';
import { ITree } from '@fluidframework/protocol-definitions';
import { ITreeEntry } from '@fluidframework/protocol-definitions';
Expand Down
2 changes: 1 addition & 1 deletion api-report/experimental-tree.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import { ISharedObjectEvents } from '@fluidframework/shared-object-base';
import { ISummaryTreeWithStats } from '@fluidframework/runtime-definitions';
import { ITelemetryBaseEvent } from '@fluidframework/core-interfaces';
import { ITelemetryLoggerExt } from '@fluidframework/telemetry-utils';
import { ITelemetryProperties } from '@fluidframework/common-definitions';
import { ITelemetryProperties } from '@fluidframework/core-interfaces';
import type { Serializable } from '@fluidframework/datastore-definitions';
import { SharedObject } from '@fluidframework/shared-object-base';
import { TypedEventEmitter } from '@fluidframework/common-utils';
Expand Down
2 changes: 1 addition & 1 deletion api-report/runtime-definitions.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import { ITelemetryBaseLogger } from '@fluidframework/core-interfaces';
import { ITree } from '@fluidframework/protocol-definitions';
import type { IUser } from '@fluidframework/protocol-definitions';
import { SummaryTree } from '@fluidframework/protocol-definitions';
import { TelemetryEventPropertyType } from '@fluidframework/common-definitions';
import { TelemetryEventPropertyType } from '@fluidframework/core-interfaces';

// @public
export type AliasResult = "Success" | "Conflict" | "AlreadyAliased";
Expand Down
2 changes: 1 addition & 1 deletion api-report/runtime-utils.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import { ITelemetryContext } from '@fluidframework/runtime-definitions';
import { ITree } from '@fluidframework/protocol-definitions';
import { SummaryObject } from '@fluidframework/protocol-definitions';
import { SummaryType } from '@fluidframework/protocol-definitions';
import { TelemetryEventPropertyType } from '@fluidframework/common-definitions';
import { TelemetryEventPropertyType } from '@fluidframework/core-interfaces';

// @public (undocumented)
export function addBlobToSummary(summary: ISummaryTreeWithStats, key: string, content: string | Uint8Array): void;
Expand Down
5 changes: 2 additions & 3 deletions api-report/telemetry-utils.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import { ITelemetryErrorEvent } from '@fluidframework/core-interfaces';
import { ITelemetryGenericEvent } from '@fluidframework/core-interfaces';
import { ITelemetryPerformanceEvent } from '@fluidframework/core-interfaces';
import { ITelemetryProperties } from '@fluidframework/core-interfaces';
import { ITelemetryProperties as ITelemetryProperties_2 } from '@fluidframework/common-definitions';
import { Lazy } from '@fluidframework/common-utils';
import { TelemetryEventCategory } from '@fluidframework/core-interfaces';
import { TelemetryEventPropertyType } from '@fluidframework/core-interfaces';
Expand Down Expand Up @@ -110,10 +109,10 @@ export interface IFluidErrorAnnotations {

// @public
export interface IFluidErrorBase extends Error {
addTelemetryProperties: (props: ITelemetryProperties_2) => void;
addTelemetryProperties: (props: ITelemetryProperties) => void;
readonly errorInstanceId: string;
readonly errorType: string;
getTelemetryProperties(): ITelemetryProperties_2;
getTelemetryProperties(): ITelemetryProperties;
readonly message: string;
readonly name: string;
readonly stack?: string;
Expand Down
4 changes: 2 additions & 2 deletions azure/packages/azure-client/src/interfaces.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@
* Copyright (c) Microsoft Corporation and contributors. All rights reserved.
* Licensed under the MIT License.
*/
import { ITelemetryBaseLogger } from "@fluidframework/core-interfaces";
import { ITelemetryBaseLogger } from "@fluidframework/common-definitions";
import { IMember, IServiceAudience } from "@fluidframework/fluid-static";
import { IUser } from "@fluidframework/protocol-definitions";
import { ITokenProvider } from "@fluidframework/routerlicious-driver";
import { IConfigProviderBase } from "@fluidframework/telemetry-utils";
import { ICompressionStorageConfig } from "@fluidframework/driver-utils";

// Re-export so developers can build loggers without pulling in common-definitions
export { ITelemetryBaseEvent, ITelemetryBaseLogger } from "@fluidframework/core-interfaces";
export { ITelemetryBaseEvent, ITelemetryBaseLogger } from "@fluidframework/common-definitions";

/**
* Props for initializing a new AzureClient instance
Expand Down
1 change: 0 additions & 1 deletion experimental/dds/sequence-deprecated/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@
"@fluid-tools/build-cli": "^0.20.0",
"@fluidframework/build-common": "^1.2.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/eslint-config-fluid": "^2.0.0",
"@fluidframework/mocha-test-setup": "workspace:~",
"@fluidframework/test-runtime-utils": "workspace:~",
Expand Down
4 changes: 2 additions & 2 deletions experimental/dds/tree/src/Checkout.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@

import { assert } from '@fluidframework/common-utils';
import { ChildLogger, EventEmitterWithErrorHandling, ITelemetryLoggerExt } from '@fluidframework/telemetry-utils';
import { IErrorEvent, ITelemetryProperties } from '@fluidframework/common-definitions';
import { IDisposable } from '@fluidframework/core-interfaces';
import { IErrorEvent } from '@fluidframework/common-definitions';
import { IDisposable, ITelemetryProperties } from '@fluidframework/core-interfaces';
import { assertWithMessage, fail, RestOrArray, unwrapRestOrArray } from './Common';
import { EditId } from './Identifiers';
import { CachingLogViewer } from './LogViewer';
Expand Down
2 changes: 1 addition & 1 deletion experimental/dds/tree/src/SharedTree.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import {
ISharedObjectEvents,
SharedObject,
} from '@fluidframework/shared-object-base';
import { ITelemetryProperties } from '@fluidframework/common-definitions';
import { ITelemetryProperties } from '@fluidframework/core-interfaces';
import {
ITelemetryLoggerExt,
ChildLogger,
Expand Down
2 changes: 1 addition & 1 deletion experimental/dds/tree/src/SummaryBackCompatibility.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* Licensed under the MIT License.
*/

import type { ITelemetryProperties } from '@fluidframework/common-definitions';
import type { ITelemetryProperties } from '@fluidframework/core-interfaces';
import type { IFluidSerializer } from '@fluidframework/shared-object-base';
import { fail } from './Common';
import { getNumberOfHandlesFromEditLogSummary } from './EditLog';
Expand Down
1 change: 0 additions & 1 deletion packages/common/container-definitions/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
"@fluid-tools/build-cli": "^0.20.0",
"@fluidframework/build-common": "^1.2.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/container-definitions-previous": "npm:@fluidframework/[email protected]",
"@fluidframework/eslint-config-fluid": "^2.0.0",
"@microsoft/api-extractor": "^7.34.4",
Expand Down
2 changes: 1 addition & 1 deletion packages/common/container-definitions/src/error.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* Licensed under the MIT License.
*/

import { ITelemetryProperties } from "@fluidframework/common-definitions";
import { ITelemetryProperties } from "@fluidframework/core-interfaces";

/**
* Different error types the Container may report out to the Host
Expand Down
1 change: 0 additions & 1 deletion packages/common/core-interfaces/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
"@fluid-tools/build-cli": "^0.20.0",
"@fluidframework/build-common": "^1.2.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/core-interfaces-previous": "npm:@fluidframework/[email protected]",
"@fluidframework/eslint-config-fluid": "^2.0.0",
"@microsoft/api-extractor": "^7.34.4",
Expand Down
1 change: 0 additions & 1 deletion packages/common/core-utils/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@
"@fluid-tools/build-cli": "^0.20.0",
"@fluidframework/build-common": "^1.2.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/eslint-config-fluid": "^2.0.0",
"@fluidframework/mocha-test-setup": "workspace:~",
"@microsoft/api-extractor": "^7.34.4",
Expand Down
1 change: 0 additions & 1 deletion packages/common/driver-definitions/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@
"@fluid-tools/build-cli": "^0.20.0",
"@fluidframework/build-common": "^1.2.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/driver-definitions-previous": "npm:@fluidframework/[email protected]",
"@fluidframework/eslint-config-fluid": "^2.0.0",
"@microsoft/api-extractor": "^7.34.4",
Expand Down
1 change: 0 additions & 1 deletion packages/dds/cell/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@
"@fluid-tools/build-cli": "^0.20.0",
"@fluidframework/build-common": "^1.2.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/cell-previous": "npm:@fluidframework/[email protected]",
"@fluidframework/eslint-config-fluid": "^2.0.0",
"@fluidframework/mocha-test-setup": "workspace:~",
Expand Down
1 change: 0 additions & 1 deletion packages/dds/counter/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@
"@fluid-tools/build-cli": "^0.20.0",
"@fluidframework/build-common": "^1.2.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/counter-previous": "npm:@fluidframework/[email protected]",
"@fluidframework/eslint-config-fluid": "^2.0.0",
"@fluidframework/mocha-test-setup": "workspace:~",
Expand Down
1 change: 0 additions & 1 deletion packages/dds/ink/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@
"@fluid-tools/build-cli": "^0.20.0",
"@fluidframework/build-common": "^1.2.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/eslint-config-fluid": "^2.0.0",
"@fluidframework/ink-previous": "npm:@fluidframework/[email protected]",
"@fluidframework/mocha-test-setup": "workspace:~",
Expand Down
1 change: 0 additions & 1 deletion packages/dds/map/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@
"@fluid-tools/build-cli": "^0.20.0",
"@fluidframework/build-common": "^1.2.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/eslint-config-fluid": "^2.0.0",
"@fluidframework/map-previous": "npm:@fluidframework/[email protected]",
"@fluidframework/mocha-test-setup": "workspace:~",
Expand Down
1 change: 0 additions & 1 deletion packages/dds/matrix/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@
"@fluid-tools/build-cli": "^0.20.0",
"@fluidframework/build-common": "^1.2.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/eslint-config-fluid": "^2.0.0",
"@fluidframework/matrix-previous": "npm:@fluidframework/[email protected]",
"@fluidframework/mocha-test-setup": "workspace:~",
Expand Down
1 change: 0 additions & 1 deletion packages/dds/merge-tree/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@
"@fluid-tools/build-cli": "^0.20.0",
"@fluidframework/build-common": "^1.2.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/eslint-config-fluid": "^2.0.0",
"@fluidframework/merge-tree-previous": "npm:@fluidframework/[email protected]",
"@fluidframework/mocha-test-setup": "workspace:~",
Expand Down
1 change: 0 additions & 1 deletion packages/dds/ordered-collection/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@
"@fluid-tools/build-cli": "^0.20.0",
"@fluidframework/build-common": "^1.2.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/eslint-config-fluid": "^2.0.0",
"@fluidframework/mocha-test-setup": "workspace:~",
"@fluidframework/ordered-collection-previous": "npm:@fluidframework/[email protected]",
Expand Down
1 change: 0 additions & 1 deletion packages/dds/register-collection/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@
"@fluid-tools/build-cli": "^0.20.0",
"@fluidframework/build-common": "^1.2.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/eslint-config-fluid": "^2.0.0",
"@fluidframework/mocha-test-setup": "workspace:~",
"@fluidframework/register-collection-previous": "npm:@fluidframework/[email protected]",
Expand Down
1 change: 0 additions & 1 deletion packages/dds/sequence/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@
"@fluid-tools/build-cli": "^0.20.0",
"@fluidframework/build-common": "^1.2.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/eslint-config-fluid": "^2.0.0",
"@fluidframework/gitresources": "^0.1039.1000",
"@fluidframework/mocha-test-setup": "workspace:~",
Expand Down
1 change: 0 additions & 1 deletion packages/dds/shared-object-base/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@
"@fluid-tools/build-cli": "^0.20.0",
"@fluidframework/build-common": "^1.2.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/eslint-config-fluid": "^2.0.0",
"@fluidframework/mocha-test-setup": "workspace:~",
"@fluidframework/shared-object-base-previous": "npm:@fluidframework/[email protected]",
Expand Down
1 change: 0 additions & 1 deletion packages/dds/shared-summary-block/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@
"@fluid-tools/build-cli": "^0.20.0",
"@fluidframework/build-common": "^1.2.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/eslint-config-fluid": "^2.0.0",
"@fluidframework/mocha-test-setup": "workspace:~",
"@fluidframework/shared-summary-block-previous": "npm:@fluidframework/[email protected]",
Expand Down
1 change: 0 additions & 1 deletion packages/dds/task-manager/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@
"@fluid-tools/build-cli": "^0.20.0",
"@fluidframework/build-common": "^1.2.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/eslint-config-fluid": "^2.0.0",
"@fluidframework/mocha-test-setup": "workspace:~",
"@fluidframework/task-manager-previous": "npm:@fluidframework/[email protected]",
Expand Down
1 change: 0 additions & 1 deletion packages/drivers/debugger/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
"@fluid-tools/build-cli": "^0.20.0",
"@fluidframework/build-common": "^1.2.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/debugger-previous": "npm:@fluidframework/[email protected]",
"@fluidframework/eslint-config-fluid": "^2.0.0",
"@microsoft/api-extractor": "^7.34.4",
Expand Down
2 changes: 0 additions & 2 deletions packages/drivers/driver-base/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@
"temp-directory": "nyc/.nyc_output"
},
"dependencies": {
"@fluidframework/common-definitions": "^0.20.1",
"@fluidframework/common-utils": "^1.1.1",
"@fluidframework/core-interfaces": "workspace:~",
"@fluidframework/driver-definitions": "workspace:~",
Expand All @@ -73,7 +72,6 @@
"@fluid-tools/build-cli": "^0.20.0",
"@fluidframework/build-common": "^1.2.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/driver-base-previous": "npm:@fluidframework/[email protected]",
"@fluidframework/eslint-config-fluid": "^2.0.0",
"@fluidframework/mocha-test-setup": "workspace:~",
Expand Down
3 changes: 1 addition & 2 deletions packages/drivers/driver-base/src/documentDeltaConnection.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ import {
ITokenClaims,
ScopeType,
} from "@fluidframework/protocol-definitions";
import { ITelemetryProperties } from "@fluidframework/common-definitions";
import { IDisposable } from "@fluidframework/core-interfaces";
import { IDisposable, ITelemetryProperties } from "@fluidframework/core-interfaces";
import {
ITelemetryLoggerExt,
ChildLogger,
Expand Down
2 changes: 0 additions & 2 deletions packages/drivers/driver-web-cache/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
"typetests:prepare": "flub typetests --dir . --reset --previous --normalize"
},
"dependencies": {
"@fluidframework/common-definitions": "^0.20.1",
"@fluidframework/common-utils": "^1.1.1",
"@fluidframework/core-interfaces": "workspace:~",
"@fluidframework/odsp-driver-definitions": "workspace:~",
Expand All @@ -48,7 +47,6 @@
"@fluid-tools/build-cli": "^0.20.0",
"@fluidframework/build-common": "^1.2.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/driver-web-cache-previous": "npm:@fluidframework/[email protected]",
"@fluidframework/eslint-config-fluid": "^2.0.0",
"@microsoft/api-extractor": "^7.34.4",
Expand Down
2 changes: 0 additions & 2 deletions packages/drivers/file-driver/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
"typetests:prepare": "flub typetests --dir . --reset --previous --normalize"
},
"dependencies": {
"@fluidframework/common-definitions": "^0.20.1",
"@fluidframework/common-utils": "^1.1.1",
"@fluidframework/core-interfaces": "workspace:~",
"@fluidframework/driver-definitions": "workspace:~",
Expand All @@ -44,7 +43,6 @@
"@fluid-tools/build-cli": "^0.20.0",
"@fluidframework/build-common": "^1.2.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/eslint-config-fluid": "^2.0.0",
"@fluidframework/file-driver-previous": "npm:@fluidframework/[email protected]",
"@microsoft/api-extractor": "^7.34.4",
Expand Down
1 change: 0 additions & 1 deletion packages/drivers/fluidapp-odsp-urlResolver/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
"@fluid-tools/fluidapp-odsp-urlresolver-previous": "npm:@fluid-tools/[email protected]",
"@fluidframework/build-common": "^1.2.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/eslint-config-fluid": "^2.0.0",
"@fluidframework/mocha-test-setup": "workspace:~",
"@types/mocha": "^9.1.1",
Expand Down
2 changes: 0 additions & 2 deletions packages/drivers/local-driver/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@
"temp-directory": "nyc/.nyc_output"
},
"dependencies": {
"@fluidframework/common-definitions": "^0.20.1",
"@fluidframework/common-utils": "^1.1.1",
"@fluidframework/core-interfaces": "workspace:~",
"@fluidframework/driver-base": "workspace:~",
Expand All @@ -85,7 +84,6 @@
"@fluid-tools/build-cli": "^0.20.0",
"@fluidframework/build-common": "^1.2.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/eslint-config-fluid": "^2.0.0",
"@fluidframework/local-driver-previous": "npm:@fluidframework/[email protected]",
"@fluidframework/mocha-test-setup": "workspace:~",
Expand Down
1 change: 0 additions & 1 deletion packages/drivers/odsp-driver-definitions/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
"@fluid-tools/build-cli": "^0.20.0",
"@fluidframework/build-common": "^1.2.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/eslint-config-fluid": "^2.0.0",
"@fluidframework/odsp-driver-definitions-previous": "npm:@fluidframework/[email protected]",
"@fluidframework/protocol-definitions": "^1.1.0",
Expand Down
1 change: 0 additions & 1 deletion packages/drivers/odsp-driver/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@
"@fluid-tools/build-cli": "^0.20.0",
"@fluidframework/build-common": "^1.2.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/build-tools": "^0.20.0",
"@fluidframework/eslint-config-fluid": "^2.0.0",
"@fluidframework/mocha-test-setup": "workspace:~",
"@fluidframework/odsp-driver-previous": "npm:@fluidframework/[email protected]",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

import { default as AbortController } from "abort-controller";
import { v4 as uuid } from "uuid";
import { ITelemetryProperties } from "@fluidframework/common-definitions";
import { ITelemetryProperties } from "@fluidframework/core-interfaces";
import { validateMessages } from "@fluidframework/driver-base";
import { ITelemetryLoggerExt, PerformanceEvent } from "@fluidframework/telemetry-utils";
import { assert } from "@fluidframework/common-utils";
Expand Down
2 changes: 1 addition & 1 deletion packages/drivers/odsp-driver/src/vroom.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/

import { v4 as uuid } from "uuid";
import { ITelemetryProperties } from "@fluidframework/common-definitions";
import { ITelemetryProperties } from "@fluidframework/core-interfaces";
import { ITelemetryLoggerExt, PerformanceEvent } from "@fluidframework/telemetry-utils";
import {
InstrumentedStorageTokenFetcher,
Expand Down
Loading

0 comments on commit 7458e8a

Please sign in to comment.