Skip to content

Commit

Permalink
OpRoundtripTime telemetry is wrong (#15620)
Browse files Browse the repository at this point in the history
## Description

In connections where have 2 or more OpRoundtripTime triggered within the
same connection, we will have incorrect values as we we do not reset
opProcessingTimes.
The second time and every time afterwards, durationNetwork is going to
be empty because it gets reset after the OpRoundtripTime is triggered
but opProcessingTimes.outboundPushEventTime does not get reset.

[Task
4006](https://dev.azure.com/fluidframework/internal/_workitems/edit/4006).
  • Loading branch information
NicholasCouri authored May 17, 2023
1 parent 3138567 commit 94ac51f
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,7 @@ class OpPerfTelemetry {
});
this.clientSequenceNumberForLatencyStatistics = undefined;
this.opPerfData = {};
this.opProcessingTimes = {};
}
}
}
Expand Down

0 comments on commit 94ac51f

Please sign in to comment.