Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContainerRuntime: Remove the contents property of batchBegin/batchEnd's "op" event arg #22846

Closed
kian-thompson opened this issue Oct 18, 2024 · 0 comments · Fixed by #22791
Closed

ContainerRuntime: Remove the contents property of batchBegin/batchEnd's "op" event arg #22846

kian-thompson opened this issue Oct 18, 2024 · 0 comments · Fixed by #22791
Assignees
@kian-thompson
Labels
api deprecation Changes to a deprecated API triage

Comments

@kian-thompson
Copy link
Contributor

Deprecated API

ContainerRuntime's 'batchBegin'/'batchEnd' events: Removing the contents property on event arg op

Context

The 'batchBegin'/'batchEnd' events on ContainerRuntime indicate when a batch is beginning/finishing being processed.
The contents property on there is not useful or relevant when reasoning over incoming changes at the batch level. So, it has been removed from the op event arg.

#22791
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kian-thompson kian-thompson

Labels
api deprecation Changes to a deprecated API triage
Projects
None yet
Milestone
No milestone
1 participant
@kian-thompson