-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ContainerRuntime: Remove the contents property of batchBegin/batchEnd's "op" event arg #22791
ContainerRuntime: Remove the contents property of batchBegin/batchEnd's "op" event arg #22791
Conversation
…and "batchEnd" events
Converting to Draft until |
I'll be OOF until 11/14. I'll plan to bring this in for 2.10.0 at that point if it's not too late (unless someone decides to merge this for me while I'm OOF) |
⯅ @fluid-example/bundle-size-tests: +233 Bytes
Baseline commit: 2aa0b5e |
@kian-thompson feel free to merge this if the time is right for breaking changes. Not paying attention broadly, just saw the notification that you approved it. |
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reworded the changeset a bit - approving for docs.
PR #22791 had auto-merge turned on, so a suggested change to the changeset wasn't made. #22791 (comment)
Description
Fixes AB#19784
ContainerRuntime's 'batchBegin'/'batchEnd' events: Removing the
contents
property on event argop
The 'batchBegin'/'batchEnd' events on ContainerRuntime indicate when a batch is beginning/finishing being processed.
The
contents
property on there is not useful or relevant when reasoning over incoming changes at the batch level.So it has been removed from the
op
event arg.Breaking Changes
Yes this is a breaking change. See changeset.