refactor(fluid-build): Exclude build-tools release groups from fluid-build #12415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…build The build-tools release group can cause problems with fluid-build's incremental support. As a short term mitigation, I've changed the `--all` argument to exclude a list of release groups (only build-tools right now) and added a `--forceAll` option that will _really_ include everything in the repo.
alexvy86
reviewed
Oct 17, 2022
Comment on lines
+105
to
+113
| if (options.azure || options.all) { | ||
| monoReposToConsider.push(MonoRepoKind.Azure); | ||
| } | ||
| if (options.server || options.all) { | ||
| monoReposToConsider.push(MonoRepoKind.Server); | ||
| } | ||
| if ((!options.azure && !options.server) || options.all) { | ||
| monoReposToConsider.push(MonoRepoKind.Client); | ||
| } |
There was a problem hiding this comment.
options.all will always be false here, so it's redundant?
|
This PR has been automatically marked as stale because it has had no activity for 60 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework! |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build-tools release group can cause problems with fluid-build's incremental support. As a short term mitigation, I've changed the
--allargument to exclude a list of release groups (only build-tools right now) and added a--forceAlloption that will really include everything in the repo.I think this is a better approach to the problems described in #12400.