Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client-utils): fix trace.js import of performance (#21257) #21317

Closed

Conversation

scottn12
Copy link
Contributor

@scottn12 scottn12 commented Jun 5, 2024

Fix GH #21252

Cherry pick of 925a477 & 44da14a

scottn12 and others added 3 commits June 5, 2024 13:09
…soft#20665)

Previously, we used [the 'browser'
field](https://github.com/defunctzombie/package-browser-field-spec) to
implement different entry points for browser vs. node.

This field does not appear to be supported by CloudPack. Instead, we now
use [conditional
exports](https://nodejs.org/docs/latest-v18.x/api/packages.html#conditional-exports)
in the export map.
@scottn12
Copy link
Contributor Author

scottn12 commented Jun 5, 2024

close in favor of #21321

@scottn12 scottn12 closed this Jun 5, 2024
@scottn12 scottn12 deleted the fixTraceJs branch June 6, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants