Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree: Import / Export APIs and demo #22566

Open
wants to merge 80 commits into
base: main
Choose a base branch
from

Conversation

CraigMacomber
Copy link
Contributor

Description

Added import/export options for tree content and schema, and example script using them.

Reviewer Guidance

The review process is outlined on this wiki page.

CraigMacomber and others added 30 commits July 25, 2024 12:26
Copy link
Collaborator

@msfluid-bot msfluid-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Coverage Summary

↓ packages.dds.tree.src.shared-tree:
Line Coverage Change: -0.23%    Branch Coverage Change: -0.57%
Metric NameBaseline coveragePR coverageCoverage Diff
Branch Coverage 91.34% 90.77% ↓ -0.57%
Line Coverage 97.42% 97.19% ↓ -0.23%
↑ packages.dds.tree.src.codec:
Line Coverage Change: 0.02%    Branch Coverage Change: 0.10%
Metric NameBaseline coveragePR coverageCoverage Diff
Branch Coverage 95.55% 95.65% ↑ 0.10%
Line Coverage 99.60% 99.62% ↑ 0.02%
↑ packages.dds.tree.src.feature-libraries.flex-tree:
Line Coverage Change: 0.09%    Branch Coverage Change: 0.05%
Metric NameBaseline coveragePR coverageCoverage Diff
Branch Coverage 93.37% 93.42% ↑ 0.05%
Line Coverage 89.97% 90.06% ↑ 0.09%
↑ packages.dds.tree.src.simple-tree.api:
Line Coverage Change: -0.04%    Branch Coverage Change: 1.36%
Metric NameBaseline coveragePR coverageCoverage Diff
Branch Coverage 86.49% 87.85% ↑ 1.36%
Line Coverage 81.75% 81.71% ↓ -0.04%

Baseline commit: 522f76f
Baseline build: 303346
Happy Coding!!

Code coverage comparison check passed!!

@CraigMacomber CraigMacomber changed the title tree: Import / Export demo tree: Import / Export APIs and demo Oct 24, 2024
@CraigMacomber CraigMacomber marked this pull request as ready for review October 24, 2024 19:25
@CraigMacomber CraigMacomber requested review from a team as code owners October 24, 2024 19:25
Copy link
Contributor

@jzaffiro jzaffiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments, but docs look good!

.changeset/chubby-olives-say.md Outdated Show resolved Hide resolved
.changeset/chubby-olives-say.md Outdated Show resolved Hide resolved
.changeset/chubby-olives-say.md Outdated Show resolved Hide resolved
examples/apps/tree-cli-app/README.md Outdated Show resolved Hide resolved
@CraigMacomber CraigMacomber requested a review from a team as a code owner October 29, 2024 20:26
CraigMacomber added a commit that referenced this pull request Oct 29, 2024
…#22927)

## Description

A collection of minor improvements split out from
#22566 for simplified
and more targeted review.
Copy link
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> [email protected] ci:linkcheck /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test ci:start 1313 linkcheck:full

1: starting server using command "npm run ci:start"
and when url "[ 'http://127.0.0.1:1313' ]" is responding with HTTP status code 200
running tests using command "npm run linkcheck:full"


> [email protected] ci:start
> http-server ./public --port 1313 --silent


> [email protected] linkcheck:full
> npm run linkcheck:fast -- --external


> [email protected] linkcheck:fast
> linkcheck http://localhost:1313 --skip-file skipped-urls.txt --external

Crawling...

Stats:
  440694 links
    3397 destination URLs
       2 URLs ignored
       0 warnings
       0 errors


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: tree area: dds Issues related to distributed data structures area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct base: main PRs targeted against main branch changeset-present dependencies Pull requests that update a dependency file public api change Changes to a public API size regression Significant bundle size regression (>5 KB)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants