-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unsupported Merge-Tree Types and Exposures Removed #22696
Conversation
…to prototype-deprecate-client
…to test/internal-merge-tree-client
…to seperate-segment-visabilty-interfaces
…to test/internal-merge-tree-client
…to test/remove-ISegment-deprecations
…to test/remove-ISegment-deprecations
f3815f4
to
fb201de
Compare
…to test/remove-ISegment-deprecations
…to test/internal-merge-tree-client
⯆ @fluid-example/bundle-size-tests: -827 Bytes
Baseline commit: 00062eb |
…to test/internal-merge-tree-client
Co-authored-by: Tyler Butler <[email protected]>
…to test/internal-merge-tree-client
…to test/internal-merge-tree-client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Coverage Summary
↓ packages.dds.sequence.src.intervals:
Line Coverage Change: -0.12% Branch Coverage Change: -0.16%
Metric Name | Baseline coverage | PR coverage | Coverage Diff |
---|---|---|---|
Branch Coverage | 89.47% | 89.31% | ↓ -0.16% |
Line Coverage | 96.44% | 96.32% | ↓ -0.12% |
↑ packages.dds.sequence.src:
Line Coverage Change: 0.02% Branch Coverage Change: 0.04%
Metric Name | Baseline coverage | PR coverage | Coverage Diff |
---|---|---|---|
Branch Coverage | 89.44% | 89.48% | ↑ 0.04% |
Line Coverage | 89.83% | 89.85% | ↑ 0.02% |
↑ packages.dds.merge-tree.src:
Line Coverage Change: 0.19% Branch Coverage Change: 0.04%
Metric Name | Baseline coverage | PR coverage | Coverage Diff |
---|---|---|---|
Branch Coverage | 94.90% | 94.94% | ↑ 0.04% |
Line Coverage | 97.08% | 97.27% | ↑ 0.19% |
Baseline commit: 760afc7
Baseline build: 304612
Happy Coding!!
Code coverage comparison check passed!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs nits. Approving.
Co-authored-by: Tyler Butler <[email protected]>
Co-authored-by: Tyler Butler <[email protected]>
Co-authored-by: Tyler Butler <[email protected]>
🔗 Found some broken links! 💔 Run a link check locally to find them. See linkcheck output
|
As part of ongoing improvements, several exposed internals that are unnecessary for any supported scenarios and could lead to errors if used have been removed. Since direct usage would likely result in errors, it is not expected that these changes will impact any Fluid Framework consumers.
Removed types:
In addition to removing the above types, their exposures have also been removed from interfaces and their implementations:
ISegment
,ReferencePosition
, andISerializableInterval
.Removed functions:
Removed properties:
The initial deprecations of the now changed or removed types were announced in Fluid Framework v2.2.0:
Fluid Framework v2.2.0