Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsupported Merge-Tree Types and Exposures Removed #22696

Merged
merged 91 commits into from
Nov 7, 2024

Conversation

anthony-murphy
Copy link
Contributor

@anthony-murphy anthony-murphy commented Oct 1, 2024

As part of ongoing improvements, several exposed internals that are unnecessary for any supported scenarios and could lead to errors if used have been removed. Since direct usage would likely result in errors, it is not expected that these changes will impact any Fluid Framework consumers.

Removed types:

  • IMergeTreeTextHelper
  • MergeNode
  • ObliterateInfo
  • PropertiesManager
  • PropertiesRollback
  • SegmentGroup
  • SegmentGroupCollection

In addition to removing the above types, their exposures have also been removed from interfaces and their implementations: ISegment, ReferencePosition, and ISerializableInterval.

Removed functions:

  • addProperties
  • ack

Removed properties:

  • propertyManager
  • segmentGroups

The initial deprecations of the now changed or removed types were announced in Fluid Framework v2.2.0:
Fluid Framework v2.2.0

@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: sharedstring area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: tests Tests to add, test infrastructure improvements, etc public api change Changes to a public API base: main PRs targeted against main branch labels Oct 1, 2024
@anthony-murphy anthony-murphy force-pushed the test/remove-ISegment-deprecations branch from f3815f4 to fb201de Compare October 2, 2024 18:55
@github-actions github-actions bot added the area: build Build related issues label Oct 2, 2024
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Oct 2, 2024

@fluid-example/bundle-size-tests: -827 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 464.03 KB 463.64 KB -394 Bytes
azureClient.js 562.45 KB 562.5 KB +49 Bytes
connectionState.js 724 Bytes 724 Bytes No change
containerRuntime.js 261.86 KB 261.87 KB +14 Bytes
fluidFramework.js 424.82 KB 424.84 KB +14 Bytes
loader.js 134.17 KB 134.19 KB +14 Bytes
map.js 42.71 KB 42.71 KB +7 Bytes
matrix.js 148.54 KB 148.33 KB -217 Bytes
odspClient.js 528.3 KB 528.34 KB +49 Bytes
odspDriver.js 97.84 KB 97.86 KB +21 Bytes
odspPrefetchSnapshot.js 42.81 KB 42.83 KB +14 Bytes
sharedString.js 164.58 KB 164.17 KB -412 Bytes
sharedTree.js 415.28 KB 415.29 KB +7 Bytes
Total Size 3.36 MB 3.36 MB -827 Bytes

Baseline commit: 00062eb

Generated by 🚫 dangerJS against 56b3bc0

Base automatically changed from test/internal-merge-tree-client to main November 5, 2024 23:22
@github-actions github-actions bot added changeset-present and removed area: tests Tests to add, test infrastructure improvements, etc labels Nov 5, 2024
@github-actions github-actions bot removed the area: build Build related issues label Nov 5, 2024
Copy link
Collaborator

@msfluid-bot msfluid-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Coverage Summary

↓ packages.dds.sequence.src.intervals:
Line Coverage Change: -0.12%    Branch Coverage Change: -0.16%
Metric NameBaseline coveragePR coverageCoverage Diff
Branch Coverage 89.47% 89.31% ↓ -0.16%
Line Coverage 96.44% 96.32% ↓ -0.12%
↑ packages.dds.sequence.src:
Line Coverage Change: 0.02%    Branch Coverage Change: 0.04%
Metric NameBaseline coveragePR coverageCoverage Diff
Branch Coverage 89.44% 89.48% ↑ 0.04%
Line Coverage 89.83% 89.85% ↑ 0.02%
↑ packages.dds.merge-tree.src:
Line Coverage Change: 0.19%    Branch Coverage Change: 0.04%
Metric NameBaseline coveragePR coverageCoverage Diff
Branch Coverage 94.90% 94.94% ↑ 0.04%
Line Coverage 97.08% 97.27% ↑ 0.19%

Baseline commit: 760afc7
Baseline build: 304612
Happy Coding!!

Code coverage comparison check passed!!

Copy link
Member

@tylerbutler tylerbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs nits. Approving.

.changeset/fifty-showers-divide.md Outdated Show resolved Hide resolved
.changeset/fifty-showers-divide.md Outdated Show resolved Hide resolved
.changeset/fifty-showers-divide.md Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Nov 6, 2024

🔗 Found some broken links! 💔

Run a link check locally to find them. See
https://github.com/microsoft/FluidFramework/wiki/Checking-for-broken-links-in-the-documentation for more information.

linkcheck output


> [email protected] ci:linkcheck /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test ci:start 1313 linkcheck:full

1: starting server using command "npm run ci:start"
and when url "[ 'http://127.0.0.1:1313' ]" is responding with HTTP status code 200
running tests using command "npm run linkcheck:full"


> [email protected] ci:start
> http-server ./public --port 1313 --silent


> [email protected] linkcheck:full
> npm run linkcheck:fast -- --external


> [email protected] linkcheck:fast
> linkcheck http://localhost:1313 --skip-file skipped-urls.txt --external

Crawling...

http://localhost:1313/docs/start/tree-start/
- (3430:89) 'here' => https://github.com/microsoft/FluidFramework/blob/main/packages/dds/tree/docs/main/merge-semantics.md (HTTP 404)


Stats:
  447786 links
    3441 destination URLs
       2 URLs ignored
       0 warnings
       1 errors

 ELIFECYCLE  Command failed with exit code 1.

@anthony-murphy anthony-murphy merged commit 7a03253 into main Nov 7, 2024
32 checks passed
@anthony-murphy anthony-murphy deleted the test/remove-ISegment-deprecations branch November 7, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: sharedstring area: dds Issues related to distributed data structures area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct base: main PRs targeted against main branch changeset-present public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants