-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(client-presence): Rename ISessionClient so that function/property naming is consistent #22889
Open
WillieHabi
wants to merge
2
commits into
microsoft:main
Choose a base branch
from
WillieHabi:rename-status
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+13
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: framework
Framework is a tag for issues involving the developer framework. Eg Aqueduct
public api change
Changes to a public API
base: main
PRs targeted against main branch
labels
Oct 24, 2024
msfluid-bot
reviewed
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⯅ @fluid-example/bundle-size-tests: +245 Bytes
Baseline commit: ff6a3bf |
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output
|
WillieHabi
changed the title
fix(client-presence): Rename ISessionClient.getStatus() to ISessionClient.status()
fix(client-presence): Rename ISessionClient so that function/property naming is consistent
Oct 25, 2024
WillieHabi
requested review from
jason-ha,
tylerbutler,
pk-pranshu and
kashms
October 25, 2024 16:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: examples
Changes that focus on our examples
area: framework
Framework is a tag for issues involving the developer framework. Eg Aqueduct
base: main
PRs targeted against main branch
public api change
Changes to a public API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ISessionClient functions/properties must be consistent. From what I can gather from API naming discussion, getStatus and getClientConnectionId is the preferred naming.
the status and the connectionId of session clients can change in between calls, so having a get function makes sense (even though implementation does not "do work" to give the response).