Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(client-presence): attendee connection related unit tests #22892

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

WillieHabi
Copy link
Contributor

Description

Added and edited existing attendee connection unit tests.

Moved attendeeDisconnected cases to start under 'already known' as we can't disconnect things we don't know about.

Retitled describe and it blocks so tests read like sentences

@github-actions github-actions bot added area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct base: main PRs targeted against main branch labels Oct 24, 2024
@WillieHabi WillieHabi marked this pull request as ready for review October 24, 2024 22:06
Copy link
Collaborator

@msfluid-bot msfluid-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Coverage Summary

↑ packages.framework.presence.src:
Line Coverage Change: 0.09%    Branch Coverage Change: 1.84%
Metric NameBaseline coveragePR coverageCoverage Diff
Branch Coverage 83.87% 85.71% ↑ 1.84%
Line Coverage 61.93% 62.02% ↑ 0.09%

Baseline commit: 522f76f
Baseline build: 303346
Happy Coding!!

Code coverage comparison check passed!!

@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Oct 24, 2024

@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 464.62 KB 464.65 KB +35 Bytes
azureClient.js 562.79 KB 562.83 KB +49 Bytes
connectionState.js 724 Bytes 724 Bytes No change
containerRuntime.js 262.21 KB 262.22 KB +14 Bytes
fluidFramework.js 406.75 KB 406.77 KB +14 Bytes
loader.js 134.17 KB 134.18 KB +14 Bytes
map.js 42.71 KB 42.71 KB +7 Bytes
matrix.js 148.54 KB 148.54 KB +7 Bytes
odspClient.js 528.73 KB 528.78 KB +49 Bytes
odspDriver.js 97.84 KB 97.86 KB +21 Bytes
odspPrefetchSnapshot.js 42.81 KB 42.82 KB +14 Bytes
sharedString.js 164.73 KB 164.74 KB +7 Bytes
sharedTree.js 397.21 KB 397.22 KB +7 Bytes
Total Size 3.33 MB 3.33 MB +245 Bytes

Baseline commit: 522f76f

Generated by 🚫 dangerJS against 3d7317c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants