Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(client-presence): updates for example attendee disconnected use #22913

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

WillieHabi
Copy link
Contributor

@WillieHabi WillieHabi commented Oct 28, 2024

Description

This PR adds new "attendeeDisconnected" event to Azure client external-controller example. When a client leaves each connected client is update in the "Remote Activity Log".

We also now show the connectivity status of attendees with the ability of session clients to connect/reconnect with the same sessionID.

Other presence related improvements:

  • Changes made to update the local attendee status on disconnect
  • "attendee joined" event fires when a known attendee rejoins with a new connectionID

@github-actions github-actions bot added area: examples Changes that focus on our examples base: main PRs targeted against main branch labels Oct 28, 2024
Copy link
Collaborator

@msfluid-bot msfluid-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Coverage Summary

↓ packages.framework.presence.src:
Line Coverage Change: -0.20%    Branch Coverage Change: -2.21%
Metric NameBaseline coveragePR coverageCoverage Diff
Branch Coverage 83.87% 81.66% ↓ -2.21%
Line Coverage 61.93% 61.73% ↓ -0.20%

Baseline commit: 522f76f
Baseline build: 303346
Happy Coding!!

Code coverage comparison check failed!!
More Details: Readme

  • Skip This Check!!

What to do if the code coverage check fails:

  • Ideally, add more tests to increase the code coverage for the package(s) whose code-coverage regressed.

  • If a regression is causing the build to fail and is due to removal of tests, removal of code with lots of tests or any other valid reason, there is a checkbox further up in this comment that determines if the code coverage check should fail the build or not. You can check the box and trigger the build again. The test coverage analysis will still be done, but it will not fail the build if a regression is detected.

  • Unchecking the checkbox and triggering another build should go back to failing the build if a test-coverage regression is detected.

  • You can check which lines are covered or not covered by your tests with these steps:

    • Go to the PR ADO build.
    • Click on the link to see its published artifacts. You will see an artifact named codeCoverageAnalysis, which you can expand to reach to a particular source file's coverage html which will show which lines are covered/not covered by your tests.
    • You can also run different kind of tests locally with :coverage tests commands to find out the coverage.

@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 462.72 KB 462.76 KB +35 Bytes
azureClient.js 560.3 KB 560.35 KB +49 Bytes
connectionState.js 724 Bytes 724 Bytes No change
containerRuntime.js 261.67 KB 261.68 KB +14 Bytes
fluidFramework.js 405.97 KB 405.98 KB +14 Bytes
loader.js 134.16 KB 134.18 KB +14 Bytes
map.js 42.46 KB 42.46 KB +7 Bytes
matrix.js 148.29 KB 148.29 KB +7 Bytes
odspClient.js 526.83 KB 526.88 KB +49 Bytes
odspDriver.js 97.84 KB 97.86 KB +21 Bytes
odspPrefetchSnapshot.js 42.81 KB 42.82 KB +14 Bytes
sharedString.js 164.48 KB 164.49 KB +7 Bytes
sharedTree.js 396.43 KB 396.43 KB +7 Bytes
Total Size 3.32 MB 3.32 MB +245 Bytes

Baseline commit: 199b9d0

Generated by 🚫 dangerJS against ab6aae2

@WillieHabi WillieHabi marked this pull request as draft October 30, 2024 19:21
@github-actions github-actions bot added the area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct label Oct 30, 2024
@WillieHabi WillieHabi changed the title test(client-presence): example attendee disconnected use improvement(client-presence): updates for example attendee disconnected use Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants