Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build-infrastructure): Add setVersion API #22919

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

tylerbutler
Copy link
Member

@tylerbutler tylerbutler commented Oct 29, 2024

This change adds a setVersion API that acts on several packages.

AB#21855

@tylerbutler tylerbutler marked this pull request as draft October 29, 2024 01:10
@github-actions github-actions bot added area: build Build related issues public api change Changes to a public API base: main PRs targeted against main branch labels Oct 29, 2024
@tylerbutler tylerbutler changed the title Bt build infra versions 04 feat(build-infrastructure): Add setVersion API Oct 29, 2024
@tylerbutler tylerbutler marked this pull request as ready for review October 29, 2024 01:17
@tylerbutler tylerbutler requested review from zhenmichael and a team October 29, 2024 01:18
build-tools/packages/build-infrastructure/src/versions.ts Outdated Show resolved Hide resolved
build-tools/packages/build-infrastructure/src/versions.ts Outdated Show resolved Hide resolved
describe("setVersion", () => {
afterEach(async () => {
await git.checkout(["HEAD", "--", testRepoRoot]);
repo.reload();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not necessary to re-assign the release groups and workspaces after reloading the repo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, I don't think so. The reload operation just reloads the packages' data from disk. It doesn't actually load the IFluid repo from config again. That is, this is not the same as creating a new IFluidRepo. So the references should all stay the same after reload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: build Build related issues base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants