feat(build-infrastructure): Add setVersion API #22919
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: build
tylerbutler
changed the title
tylerbutler
force-pushed
the
bt-build-infra-versions-04
branch
from
8e2237b
to
5c83787
Compare
alexvy86
reviewed
Oct 29, 2024
| describe("setVersion", () => { | ||
| afterEach(async () => { | ||
| await git.checkout(["HEAD", "--", testRepoRoot]); | ||
| repo.reload(); |
There was a problem hiding this comment.
It's not necessary to re-assign the release groups and workspaces after reloading the repo?
There was a problem hiding this comment.
Hmmm, I don't think so. The reload operation just reloads the packages' data from disk. It doesn't actually load the IFluid repo from config again. That is, this is not the same as creating a new IFluidRepo. So the references should all stay the same after reload.
Co-authored-by: Alex Villarreal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a
setVersionAPI that acts on several packages.AB#21855