feat(build-tools): Add generate:node10Entrypoints command #22937
Conversation
github-actions
bot
added
base: main
sonalideshpandemsft
force-pushed
the
node10-compat-cmd
branch
from
628b498
to
82bfb61
Compare
sonalideshpandemsft
force-pushed
the
node10-compat-cmd
branch
from
82bfb61
to
821fe4f
Compare
github-actions
bot
removed
the
dependencies
| @@ -60,3 +60,4 @@ export { | |||
| } from "./release.js"; | |||
| export { LayerGraph } from "./layerGraph.js"; | |||
| export { type Handler, policyHandlers } from "./repoPolicyCheck/index.js"; | |||
| export { Node10CompatExportData } from "./packageExports.js"; | |||
There was a problem hiding this comment.
As in the other PR, just import directly from the submodules and remove the export here.
| // Reads and parses the `tsconfig.json` file in the current directory. | ||
| export async function readTsConfig(): Promise<TsConfigJson> { | ||
| const tsConfigContent = await fs.readFile("./tsconfig.json", { encoding: "utf8" }); | ||
| return JSON5.parse(tsConfigContent); | ||
| } |
There was a problem hiding this comment.
Since you need these util functions in both commands now, put them somewhere in library.
|
|
||
| `; | ||
|
|
||
| async function generateNode10TypeEntrypoints( |
There was a problem hiding this comment.
Is this the same as the exported function from library/commands/? Any reason not to use the exported function?
There was a problem hiding this comment.
My understanding is generateEntrypoints will be deprecated and eventually removed once sourceEntrypoints is merged. It doesn't seem appropriate for the Node 10 function to be included under generateSourceEntrypoints, and I believe it would be better to isolate Node 10 functions since there are not many of them.
A minor difference is that the header varies, while the rest remains the same.
| export function mapExportPathsFromPackage( | ||
| packageJson: PackageJson, | ||
| emitDeclarationOnly: boolean, | ||
| logger?: Logger, | ||
| ): Map<string, Node10CompatExportData> { |
There was a problem hiding this comment.
Should be replaceable with a shared function, maybe even the one in generate:typetests.
This PR add a new command to generate node10 type declaration entrypoints. Most of the node10 code is extracted from generate entrypoint command.