-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more portions of the path to r11s request errors #22943
Merged
kian-thompson
merged 3 commits into
microsoft:main
from
kian-thompson:22156-additional-path-portions
Oct 31, 2024
Merged
Add more portions of the path to r11s request errors #22943
kian-thompson
merged 3 commits into
microsoft:main
from
kian-thompson:22156-additional-path-portions
Oct 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kian-thompson
requested review from
manishgargd,
arikt-ms,
a team,
pragya91,
markfields,
jatgarg,
tyler-cai-microsoft,
rajatch-ff and
MarioJGMsoft
and removed request for
a team
October 30, 2024 20:28
github-actions
bot
added
area: driver
Driver related issues
base: main
PRs targeted against main branch
labels
Oct 30, 2024
msfluid-bot
reviewed
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Coverage Summary
↑ packages.drivers.routerlicious-driver.src:
Line Coverage Change: 0.18% Branch Coverage Change: -0.10%
Metric Name | Baseline coverage | PR coverage | Coverage Diff |
---|---|---|---|
Branch Coverage | 76.79% | 76.69% | ↓ -0.10% |
Line Coverage | 54.55% | 54.73% | ↑ 0.18% |
Baseline commit: 522f76f
Baseline build: 303346
Happy Coding!!
Code coverage comparison check passed!!
⯅ @fluid-example/bundle-size-tests: +339 Bytes
Baseline commit: 522f76f |
manishgargd
approved these changes
Oct 30, 2024
arikt-ms
reviewed
Oct 30, 2024
"session", | ||
"git", | ||
"summaries", | ||
"latest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's add the following as well:
- document
- commits
- blobs
- refs
- revokeToken
- accesstoken
arikt-ms
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can add more portions of the URL path on r11s request errors. To protect against logging IDs in the URL, any path portion that does not explicitly match the list of known paths will be replaced with
REDACTED
.Continuation of #22851
Fixes AB#22156