Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more portions of the path to r11s request errors #22943

Merged

Conversation

kian-thompson
Copy link
Contributor

@kian-thompson kian-thompson commented Oct 30, 2024

We can add more portions of the URL path on r11s request errors. To protect against logging IDs in the URL, any path portion that does not explicitly match the list of known paths will be replaced with REDACTED.

Continuation of #22851

Fixes AB#22156

@github-actions github-actions bot added area: driver Driver related issues base: main PRs targeted against main branch labels Oct 30, 2024
Copy link
Collaborator

@msfluid-bot msfluid-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Coverage Summary

↑ packages.drivers.routerlicious-driver.src:
Line Coverage Change: 0.18%    Branch Coverage Change: -0.10%
Metric NameBaseline coveragePR coverageCoverage Diff
Branch Coverage 76.79% 76.69% ↓ -0.10%
Line Coverage 54.55% 54.73% ↑ 0.18%

Baseline commit: 522f76f
Baseline build: 303346
Happy Coding!!

Code coverage comparison check passed!!

@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Oct 30, 2024

@fluid-example/bundle-size-tests: +339 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 464.62 KB 464.65 KB +35 Bytes
azureClient.js 562.79 KB 562.93 KB +143 Bytes
connectionState.js 724 Bytes 724 Bytes No change
containerRuntime.js 262.21 KB 262.22 KB +14 Bytes
fluidFramework.js 406.75 KB 406.77 KB +14 Bytes
loader.js 134.17 KB 134.18 KB +14 Bytes
map.js 42.71 KB 42.71 KB +7 Bytes
matrix.js 148.54 KB 148.54 KB +7 Bytes
odspClient.js 528.73 KB 528.78 KB +49 Bytes
odspDriver.js 97.84 KB 97.86 KB +21 Bytes
odspPrefetchSnapshot.js 42.81 KB 42.82 KB +14 Bytes
sharedString.js 164.73 KB 164.74 KB +7 Bytes
sharedTree.js 397.21 KB 397.22 KB +7 Bytes
Total Size 3.33 MB 3.33 MB +339 Bytes

Baseline commit: 522f76f

Generated by 🚫 dangerJS against 9b71919

"session",
"git",
"summaries",
"latest",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add the following as well:

  • document
  • commits
  • blobs
  • refs
  • revokeToken
  • accesstoken

@kian-thompson kian-thompson enabled auto-merge (squash) October 30, 2024 23:09
@kian-thompson kian-thompson merged commit 8a833a6 into microsoft:main Oct 31, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: driver Driver related issues base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants