Respect interval start & end side on ack #22945
Merged
+43
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users of
IntervalCollection
can specify a start and endside
when adding or changing an interval. Doing so changes the behavior for the resultingstart
andend
local references put into the merge tree: using the defaultSide.Before
causes references to slide forward when the segment they exist on is removed, whereas usingSide.After
causes references to slide backward.In the common case, local reference positions sliding is initiated by removing a segment in merge-tree. However,
IntervalCollection
also reuses this slide logic when intervals are changed/added concurrently to a segment removal. This latter case did not correctly plumb through the sliding preference to the helper function it used, which gave undesirable merge semantics.Resolves AB#22191.