improvement(client): deprecation cleanup #22948
Open
+537
−367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For `merge-tree` and `sequence` packages, setup as many internal only types/values without compromising continued support for deprecated API use by customers.
github-actions
bot
added
area: dds
msfluid-bot
reviewed
Oct 31, 2024
There was a problem hiding this comment.
Code Coverage Summary
↓ packages.dds.sequence.src.intervals:
Line Coverage Change: -0.79% Branch Coverage Change: -0.16%
| Metric Name | Baseline coverage | PR coverage | Coverage Diff |
|---|---|---|---|
| Branch Coverage | 89.47% | 89.31% | ↓ -0.16% |
| Line Coverage | 96.22% | 95.43% | ↓ -0.79% |
↓ packages.dds.sequence.src:
Line Coverage Change: 0.12% Branch Coverage Change: -0.44%
| Metric Name | Baseline coverage | PR coverage | Coverage Diff |
|---|---|---|---|
| Branch Coverage | 89.47% | 89.03% | ↓ -0.44% |
| Line Coverage | 89.74% | 89.86% | ↑ 0.12% |
↓ packages.dds.merge-tree.src:
Line Coverage Change: -0.02% Branch Coverage Change: No change
| Metric Name | Baseline coverage | PR coverage | Coverage Diff |
|---|---|---|---|
| Branch Coverage | 94.90% | 94.90% | → No change |
| Line Coverage | 97.08% | 97.06% | ↓ -0.02% |
↑ packages.dds.sequence.src.intervalIndex:
Line Coverage Change: 0.01% Branch Coverage Change: No change
| Metric Name | Baseline coverage | PR coverage | Coverage Diff |
|---|---|---|---|
| Branch Coverage | 92.55% | 92.55% | → No change |
| Line Coverage | 87.31% | 87.32% | ↑ 0.01% |
Baseline commit: 522f76f
Baseline build: 303346
Happy Coding!!
Code coverage comparison check passed!!
|
Why did you create another PR which is the same as the PR i already have in progress: #22696 |
| readonly opArgs: IMergeTreeDeltaOpArgs | undefined; | ||
| } | ||
|
|
||
| // @alpha (undocumented) | ||
| export const SequenceMaintenanceEvent: { |
There was a problem hiding this comment.
this should not be exported
There was a problem hiding this comment.
at a minimum you've lost the deprecation, i'm also not sure if this is technically non-breaking in all cases. i'd rather just keep the pattern i've already got
anthony-murphy
requested changes
Oct 31, 2024
There was a problem hiding this comment.
I'd rather go with the PR i have. i don't see any particular advantage to this approach, it just seems like a highly opinionated redo of #22696
| @@ -1234,7 +1310,7 @@ export class MergeTree { | |||
| const deltaSegments: IMergeTreeSegmentDelta[] = []; | |||
| const overlappingRemoves: boolean[] = []; | |||
| pendingSegmentGroup.segments.map((pendingSegment: ISegmentLeaf) => { | |||
| const overlappingRemove = !pendingSegment.ack(pendingSegmentGroup, opArgs); | |||
| const overlappingRemove = !ackSegment(pendingSegment, pendingSegmentGroup, opArgs); | |||
There was a problem hiding this comment.
i didn't do this initially on purpose, as there was/is active development in the area, and i'm trying to not clobber other people's work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
merge-treeandsequencepackages, setup as many internal only types/values without compromising continued support for deprecated API use by customers.