Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(docs): Move static webapp config #23116

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

Josmithr
Copy link
Contributor

@Josmithr Josmithr commented Nov 15, 2024

Publishing step needs this config to live in the build output directory. Placing it under static ensures it is copied to the right place.

See Azure/static-web-apps#1071 for more details.

Confirmed that the swa-cli is able to find this when run locally. This is also how the site was setup previously, I was just misled by the documentation leading me to believe that moving it to the root was okay. It also worked using the local swa-cli tooling 🤷‍♂️

@Josmithr Josmithr requested a review from alexvy86 November 15, 2024 23:14
@github-actions github-actions bot added area: website base: main PRs targeted against main branch labels Nov 15, 2024
@Josmithr Josmithr enabled auto-merge (squash) November 15, 2024 23:15
Copy link
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> [email protected] ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> [email protected] serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> [email protected] check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  171747 links
    1640 destination URLs
    1840 URLs ignored
       0 warnings
       0 errors


@Josmithr Josmithr merged commit 0b6d14f into main Nov 15, 2024
31 checks passed
@Josmithr Josmithr deleted the docs/fix-config-location branch November 15, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: website base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants