[For 2.20] Move ContainerRuntime class to internal scope

[markfields]

Description

Fixes AB#26794
See #23329

Stop exporting ContainerRuntime class under the /legacy path. See deprecation release note

Breaking Changes

This is a breaking change since ContainerRuntime has been exported before. It's deprecated as of 2.12.0, and all known usages in partner codebases have been or are being removed.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (3)

• packages/runtime/container-runtime/api-report/container-runtime.legacy.alpha.api.md: Evaluated as low risk
• packages/runtime/container-runtime/src/containerRuntime.ts: Evaluated as low risk
• packages/framework/aqueduct/src/container-runtime-factories/baseContainerRuntimeFactory.ts: Evaluated as low risk

Comments suppressed due to low confidence (2)

packages/test/test-utils/src/testContainerRuntimeFactory.ts:91

• [nitpick] The variable name 'runtime' is ambiguous. It should be renamed to 'containerRuntime'.

public async instantiateFirstTime(runtime: ContainerRuntime): Promise<void> {

packages/test/test-utils/src/testContainerRuntimeFactory.ts:109

• [nitpick] The variable name 'runtime' is ambiguous. It should be renamed to 'containerRuntime'.

public async instantiateFromExisting(runtime: ContainerRuntime): Promise<void> {

[markfields]

@microsoft/fluid-cr-api -- I had marked this as deprecated to justify this break. Simplest thing is to remove the deprecation as I add the new type, as you see here.

But taking a step back, I think preInitialize, along with instantiateFirstTime and instantiateFromExisting should be protected not public. Once instantiated, this class (and base class RuntimeFactoryHelper) should only be referenced via the interface IRuntimeFactory, IMO.

If we go that direction I can leave this deprecated and do a follow-up PR to deprecate the others, and then in 2.30 switch them all to protected. Maybe I'm missing something though. Thoughts?

See also the deprecation release note for when I marked this as deprecated.

[anthony-murphy]

i would only leave it deprecated if you plan follow up and finish it, otherwise i'd just file a bug, but let the person who takes it on do the deprecation

[anthony-murphy]

🥳

[github-actions]

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output

> [email protected] ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> [email protected] serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> [email protected] check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  170492 links
    1603 destination URLs
    1838 URLs ignored
       0 warnings
       0 errors

[jzaffiro]

Approved for docs!