Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Reverting change due to Fluid-Loop pipeline integration failure. (#23874)" #23876

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

jatgarg
Copy link
Contributor

@jatgarg jatgarg commented Feb 19, 2025

Description

Revert "Reverting change due to Fluid-Loop pipeline integration failure. (#23874) because some unwanted changes got pushed with the revert.

@jatgarg jatgarg self-assigned this Feb 19, 2025
@Copilot Copilot bot review requested due to automatic review settings February 19, 2025 02:15

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 257 out of 274 changed files in this pull request and generated no comments.

Files not reviewed (17)
  • azure/packages/azure-local-service/package.json: Language not supported
  • azure/packages/azure-service-utils/package.json: Language not supported
  • examples/apps/ai-collab/package.json: Language not supported
  • examples/apps/attributable-map/package.json: Language not supported
  • examples/apps/collaborative-textarea/package.json: Language not supported
  • examples/apps/contact-collection/package.json: Language not supported
  • examples/apps/data-object-grid/package.json: Language not supported
  • examples/apps/presence-tracker/package.json: Language not supported
  • examples/apps/staging/package.json: Language not supported
  • examples/apps/task-selection/package.json: Language not supported
  • examples/apps/tree-cli-app/package.json: Language not supported
  • examples/apps/tree-comparison/package.json: Language not supported
  • examples/benchmarks/bubblebench/baseline/package.json: Language not supported
  • examples/benchmarks/bubblebench/common/package.json: Language not supported
  • examples/benchmarks/bubblebench/experimental-tree/package.json: Language not supported
  • examples/benchmarks/bubblebench/ot/package.json: Language not supported
  • examples/benchmarks/bubblebench/shared-tree/package.json: Language not supported
@github-actions github-actions bot added area: build Build related issues area: dds Issues related to distributed data structures area: dds: propertydds area: dds: sharedstring area: dds: tree area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc dependencies Pull requests that update a dependency file base: main PRs targeted against main branch labels Feb 19, 2025
Copy link
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> [email protected] ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> [email protected] serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> [email protected] check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  160781 links
    1452 destination URLs
    1683 URLs ignored
       0 warnings
       0 errors


@jatgarg jatgarg merged commit 0787c9e into microsoft:main Feb 19, 2025
41 checks passed
@jatgarg jatgarg deleted the rr branch February 19, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: build Build related issues area: dds: propertydds area: dds: sharedstring area: dds: tree area: dds Issues related to distributed data structures area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants