Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move insecureUrlResolver to packages/loader/driver-utils #7537

Conversation

tyler-cai-microsoft
Copy link
Contributor

@tyler-cai-microsoft tyler-cai-microsoft commented Sep 21, 2021

Issue: #5917

Refactor the location of the insecureUrlResolver.ts file as

packages/runtime should have zero references to IUrlResolver or IResolvedUrl.

Verified

This commit was signed with the committer’s verified signature.
xpaczka Michał Paczyński
@github-actions github-actions bot added area: examples Changes that focus on our examples area: loader Loader related issues area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc area: website documentation Improvements or additions to documentation public api change Changes to a public API labels Sep 21, 2021

Verified

This commit was signed with the committer’s verified signature.
xpaczka Michał Paczyński

Verified

This commit was signed with the committer’s verified signature.
xpaczka Michał Paczyński
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Sep 21, 2021

Verified

This commit was signed with the committer’s verified signature.
xpaczka Michał Paczyński

Verified

This commit was signed with the committer’s verified signature.
xpaczka Michał Paczyński

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was signed with the committer’s verified signature.
jagodarybacka Jagoda Rybacka

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@github-actions
Copy link
Contributor

Broken link report 👍🏻

🔗 No broken links found! ✅

Your attention to detail is admirable.

@tyler-cai-microsoft tyler-cai-microsoft marked this pull request as ready for review September 23, 2021 17:44
@tyler-cai-microsoft tyler-cai-microsoft linked an issue Sep 24, 2021 that may be closed by this pull request
11 tasks
@tyler-cai-microsoft tyler-cai-microsoft linked an issue Sep 24, 2021 that may be closed by this pull request
@tyler-cai-microsoft tyler-cai-microsoft merged commit 3bf082e into microsoft:main Sep 24, 2021
@tyler-cai-microsoft tyler-cai-microsoft deleted the move-insecure-url-resolver branch September 24, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples Changes that focus on our examples area: loader Loader related issues area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc area: website public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move InsecureUrlResolver to better place
2 participants