[ci] prevent lgb.model and lgb.pkl files being left behind after testing
#6518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicklamiller
requested review from
guolinke,
jameslamb,
shiyu1994,
jmoralez and
borchero
as code owners
nicklamiller
force-pushed
the
use-tmp-paths-for-lgb-model-files
branch
from
262bfa8 to
bed0201
Compare
10 tasks
jameslamb
requested changes
Jul 4, 2024
| X, y = make_synthetic_regression() | ||
| params = {"objective": "regression", "verbose": -1} | ||
| num_train_rounds = 2 | ||
| lgb_train = lgb.Dataset(X, y, free_raw_data=False) | ||
| bst = lgb.train(params=params, train_set=lgb_train, num_boost_round=num_train_rounds) | ||
| preds_raw = bst.predict(X, raw_score=True) | ||
| model_path_txt = str(tmp_path / "lgb.model") |
There was a problem hiding this comment.
Since this was already using tmp_path, I think it's very unlikely that this one was leaving a file behind. Could you please revert the changes to this case and any others that were already using tmp_path?
jameslamb
changed the title
tmp_path to prevent lgb.model and lgb.pkl files being left behind after testingtmp_path to prevent lgb.model and lgb.pkl files being left behind after testing
jameslamb
changed the title
tmp_path to prevent lgb.model and lgb.pkl files being left behind after testinglgb.model and lgb.pkl files being left behind after testing
This reverts commit bed0201.
jameslamb
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contributes to: #6361
Specificially prevents
lgb.pklandlgb.modelfiles from being left behind after running tests by using pytest'stmp_pathfixture. One can use the reprex described in #6361 (comment) to confirm these files are no longer left behind after these changes.