Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-package] [docs] Expand class docs for Dataset #6558

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

Plenitude-ai
Copy link
Contributor

@Plenitude-ai Plenitude-ai commented Jul 18, 2024

Fixes #6511

As discussed with James Lamb in #6511 (comment), a bit more documentation about the way the lgb.Dataset is actually constructed, with a particular representation of data, could be interesting for users.

@jameslamb jameslamb added the doc label Jul 18, 2024
@jameslamb jameslamb changed the title [python-package] Documentation for lgb.Dataset's representation of data [python-package] [docs] Expand class docs for Dataset Jul 18, 2024
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for this!

As I mentioned in #6511, I'll push a commit here with the corresponding change for the R package, and then we can ask for other maintainers to review.


In the future when you use the pull-request-from-a-fork contributing process, I strongly recommend creating your own branch instead of using main / master. See #6501 (review) for some reasons and https://github.com/scipy-conference/scipy2024_sprints_first_PR/blob/main/prs_and_reviewing.md for some advice on that.

@jameslamb
Copy link
Collaborator

I've also put "fixes #6511" in the description, so that will be automatically closed when we merge this. I believe this answers your final question there.

@jameslamb jameslamb dismissed their stale review July 19, 2024 02:53

dismissing my review because I pushed commits here

@jameslamb
Copy link
Collaborator

Thanks again @Plenitude-ai . I've pushed commits updating the formatting and adding the corresponding R changes. Please follow the instructions in #6558 (comment) (sorry, it's a Microsoft requirement), and one of the other maintainers here will review when they have time.

@Plenitude-ai
Copy link
Contributor Author

Thanks again @jameslamb for your guidance. I realize it's a (very) modest one, but this is my first contribution to an open-source project so it's a great pleasure !
Thanks for your different advices on good practices in this process, i'll definitely follow them in the future.
@microsoft-github-policy-service agree company="Qwant"

@jameslamb
Copy link
Collaborator

@Plenitude-ai wonderful to hear it, thanks for choosing LightGBM for your first contribution! We really appreciate the help, and hope you'll consider contributing more in the future.

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Plenitude-ai Thanks a lot for your contribution!
And thanks @jameslamb for helping with R-package!

@jameslamb jameslamb merged commit 3d8013c into microsoft:master Jul 24, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[python-package] Training data partially available when loading exported lgb.Dataset
4 participants