Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify devcontainer #864

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

bpkroth
Copy link
Contributor

@bpkroth bpkroth commented Oct 2, 2024

Pull Request

Title

Combines container build steps to reduce devcontainer size substantially.


Description

Reduces container size from ~5.7GB to ~2.7GB by combining the following steps:

  • install conda (previously in a base image layer)
  • create the base mlos environment

This reduces the space substantially because conda's usual attempt to do hardlinks across environments is actually able to work.

The downside is that changes to base package level requirements require reinstalling all of conda again (i.e., the single large combined container layer is less cacheable).

Should help with issues like: Microsoft-CISL/sqlite-autotuning#7


Type of Change

  • 🔄 Refactor
  • Dev environment

Testing

  • time make devcontainer
  • "Rebuild devcontainer" inside VSCode
  • docker image ls to check the sizes

@bpkroth bpkroth added low priority Low-priority issue dev-env labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-env low priority Low-priority issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant