Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some tests #1573

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Fix some tests #1573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions test/integ_test/aml_model_test/test_aml_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,9 @@
# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License.
# --------------------------------------------------------------------------
import sys
from pathlib import Path
from test.integ_test.utils import get_olive_workspace_config

import pytest

from olive.azureml.azureml_client import AzureMLClientConfig
from olive.model import ModelConfig
from olive.passes.olive_pass import create_pass_from_dict
Expand All @@ -16,7 +13,6 @@
from olive.systems.azureml import AzureMLDockerConfig, AzureMLSystem


@pytest.mark.skipif(sys.version_info > (3, 8), reason="Failed with Python 3.10, need to investigate.")
def test_aml_model_pass_run(tmp_path):
# ------------------------------------------------------------------
# Azure ML System
Expand Down
2 changes: 1 addition & 1 deletion test/unit_test/passes/onnx/test_nvmo_quantization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

@pytest.mark.skipif(
version.parse(onnxruntime.__version__) > version.parse("1.20.1"),
reason="Fails on onnxruntime 1.21",
reason="ORT 1.21 doesn't support Volta anymore. Reenable this test once we switch to a new SKU.",
)
def test_nvmo_quantization(tmp_path):
ov_model = get_onnx_model()
Expand Down
5 changes: 2 additions & 3 deletions test/unit_test/systems/isolated_ort/test_isolated_ort_system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
# --------------------------------------------------------------------------
import json
import platform
import re
import shutil
import sys
import venv
Expand Down Expand Up @@ -49,11 +50,9 @@ def test_missing_isolated_system_config(self, config):
with pytest.raises(ValueError, match="python_environment_path is required for IsolatedORTSystem"):
SystemConfig.parse_obj(config)

# TODO(team): Failed in pipeline (win). Need to investigate.
@pytest.mark.skipif(True, reason="Failed in pipeline (win). Need to investigate.")
def test_invalid_isolated_system_config(self):
config = {"type": "IsolatedORT", "config": {"python_environment_path": "invalid_path"}}
with pytest.raises(ValueError, match=f"Python path {Path('invalid_path').resolve()} does not exist"):
with pytest.raises(ValueError, match=re.escape(f"Python path {Path('invalid_path').resolve()} does not exist")):
SystemConfig.parse_obj(config)


Expand Down
Loading