🏂 Inception linux snpe e2e tests #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guotuofeng
reviewed
Feb 6, 2024
| @@ -49,6 +49,7 @@ jobs: | |||
| scriptLocation: 'inlineScript' | |||
| inlineScript: | | |||
| python -m pip install pytest | |||
| python -m pip install azure-storage-blob | |||
There was a problem hiding this comment.
should this line be in requirements.txt?
There was a problem hiding this comment.
It is in requirements.txt before. But the azure-storage-blob is only used for e2e tests to download requirement sdk/models etc. When user run it locally, it is not needed. So I tried to move it here.
jambayk
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Inception linux snpe e2e tests
Checklist before requesting a review
lintrunner -a(Optional) Issue link