Add well-known symbols for ReadonlyMap and ReadonlySet #60142

milkcask · 2024-10-05T00:33:01Z

I chose not to use strict string literals or exact well-known tags like Map and Set for the same reason mentioned in #19006. Instead, I opted to use string. Contra #59417.

jakebailey · 2024-10-08T17:44:01Z

@typescript-bot test it

typescript-bot · 2024-10-08T17:44:05Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-10-08T18:18:28Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60142/merge:

Everything looks good!

typescript-bot · 2024-10-08T18:19:51Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-10-08T18:24:26Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₁	₃₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,340	_62,340	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,379	_50,379	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,454k (± 0.74%)}	_{194,004k (± 0.95%)}	_~	_192,778k	_196,424k	_{p=0.810 n=6}
_{Parse Time}	_{1.31s (± 1.24%)}	_{1.31s (± 0.57%)}	_~	_1.30s	_1.32s	_{p=0.564 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.72s (± 0.38%)}	_{9.75s (± 0.37%)}	_~	_9.71s	_9.80s	_{p=0.227 n=6}
_{Emit Time}	_{2.74s (± 0.63%)}	_{2.72s (± 0.50%)}	_~	_2.70s	_2.74s	_{p=0.118 n=6}
_{Total Time}	_{14.50s (± 0.34%)}	_{14.51s (± 0.26%)}	_~	_14.45s	_14.56s	_{p=0.571 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₃	₃₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,886	_947,900	_{+14 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_410,840	_410,840	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,790k (± 0.01%)}	_{1,224,826k (± 0.01%)}	_~	_1,224,726k	_1,224,933k	_{p=0.297 n=6}
_{Parse Time}	_{8.08s (± 0.63%)}	_{8.06s (± 0.88%)}	_~	_8.00s	_8.20s	_{p=0.293 n=6}
_{Bind Time}	_{2.28s (± 0.64%)}	_{2.27s (± 1.07%)}	_~	_2.25s	_2.31s	_{p=0.570 n=6}
_{Check Time}	_{37.68s (± 0.32%)}	_{37.83s (± 0.28%)}	_~	_37.71s	_38.00s	_{p=0.054 n=6}
_{Emit Time}	_{18.29s (± 0.25%)}	_{18.24s (± 0.36%)}	_~	_18.14s	_18.31s	_{p=0.213 n=6}
_{Total Time}	_{66.33s (± 0.17%)}	_{66.41s (± 0.18%)}	_~	_66.29s	_66.63s	_{p=0.471 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,529,678	_2,529,685	_{+7 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_916,161	_916,161	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,340,944k (± 0.00%)}	_{2,340,972k (± 0.00%)}	_~	_2,340,863k	_2,341,027k	_{p=0.261 n=6}
_{Parse Time}	_{9.38s (± 0.33%)}	_{9.40s (± 0.30%)}	_~	_9.35s	_9.43s	_{p=0.293 n=6}
_{Bind Time}	_{2.16s (± 0.63%)}	_{2.17s (± 0.54%)}	_~	_2.15s	_2.18s	_{p=0.563 n=6}
_{Check Time}	_{75.79s (± 0.43%)}	_{75.96s (± 0.56%)}	_~	_75.24s	_76.56s	_{p=0.520 n=6}
_{Emit Time}	_{0.28s (± 2.26%)}	_{0.29s (± 2.93%)}	_~	_0.28s	_0.30s	_{p=0.340 n=6}
_{Total Time}	_{87.61s (± 0.37%)}	_{87.82s (± 0.50%)}	_~	_87.09s	_88.46s	_{p=0.378 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,109	_1,258,214	_{+105 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,266	_266,266	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,422,499k (± 0.01%)}	_{2,422,523k (± 0.02%)}	_~	_2,421,826k	_2,423,008k	_{p=0.810 n=6}
_{Parse Time}	_{5.21s (± 0.86%)}	_{5.21s (± 0.54%)}	_~	_5.17s	_5.24s	_{p=0.689 n=6}
_{Bind Time}	_{1.93s (± 0.46%)}	_{1.93s (± 0.42%)}	_~	_1.92s	_1.94s	_{p=0.550 n=6}
_{Check Time}	_{35.43s (± 0.49%)}	_{35.47s (± 0.32%)}	_~	_35.29s	_35.63s	_{p=0.575 n=6}
_{Emit Time}	_{3.02s (± 1.95%)}	_{3.02s (± 1.12%)}	_~	_2.96s	_3.06s	_{p=1.000 n=6}
_{Total Time}	_{45.58s (± 0.42%)}	_{45.63s (± 0.29%)}	_~	_45.44s	_45.78s	_{p=0.378 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,109	_1,258,214	_{+105 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,266	_266,266	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,496,191k (± 0.01%)}	_{2,496,124k (± 0.02%)}	_~	_2,495,470k	_2,496,643k	_{p=0.810 n=6}
_{Parse Time}	_{5.38s (± 1.06%)}	_{5.38s (± 0.79%)}	_~	_5.32s	_5.43s	_{p=1.000 n=6}
_{Bind Time}	_{1.73s (± 0.60%)}	_{1.74s (± 0.59%)}	_~	_1.73s	_1.76s	_{p=0.134 n=6}
_{Check Time}	_{35.86s (± 0.22%)}	_{35.88s (± 0.27%)}	_~	_35.77s	_36.03s	_{p=0.748 n=6}
_{Emit Time}	_{3.06s (± 1.03%)}	_{3.04s (± 1.71%)}	_~	_2.97s	_3.09s	_{p=0.936 n=6}
_{Total Time}	_{46.04s (± 0.15%)}	_{46.03s (± 0.16%)}	_~	_45.94s	_46.16s	_{p=0.936 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_261,786	_261,795	_{+9 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,508	_106,508	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{438,786k (± 0.01%)}	_{438,801k (± 0.02%)}	_~	_438,677k	_438,888k	_{p=0.575 n=6}
_{Parse Time}	_{3.54s (± 1.12%)}	_{3.55s (± 0.66%)}	_~	_3.53s	_3.58s	_{p=0.466 n=6}
_{Bind Time}	_{1.30s (± 0.49%)}	_{1.31s (± 0.84%)}	_~	_1.29s	_1.32s	_{p=0.080 n=6}
_{Check Time}	_{18.91s (± 0.34%)}	_{18.85s (± 0.68%)}	_~	_18.66s	_19.00s	_{p=0.630 n=6}
_{Emit Time}	_{1.54s (± 0.82%)}	_{1.54s (± 1.59%)}	_~	_1.50s	_1.57s	_{p=0.805 n=6}
_{Total Time}	_{25.29s (± 0.23%)}	_{25.25s (± 0.42%)}	_~	_25.09s	_25.35s	_{p=0.748 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,919	_225,926	_{+7 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_94,415	_94,415	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,092k (± 0.01%)}	_{371,122k (± 0.02%)}	_~	_371,043k	_371,175k	_{p=0.377 n=6}
_{Parse Time}	_{3.59s (± 1.10%)}	_{3.57s (± 1.46%)}	_~	_3.47s	_3.62s	_{p=0.744 n=6}
_{Bind Time}	_{1.95s (± 0.72%)}	_{1.94s (± 1.29%)}	_~	_1.92s	_1.99s	_{p=0.460 n=6}
_{Check Time}	_{20.23s (± 0.21%)}	_{20.32s (± 0.08%)}	_{+0.09s (+ 0.43%)}	_20.30s	_20.35s	_{p=0.012 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{25.77s (± 0.30%)}	_{25.84s (± 0.28%)}	_~	_25.72s	_25.93s	_{p=0.199 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,113,197	_3,113,210	_{+13 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_1,073,140	_1,073,140	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,206,521k (± 0.00%)}	_{3,206,522k (± 0.01%)}	_~	_3,206,296k	_3,206,725k	_{p=0.936 n=6}
_{Parse Time}	_{14.03s (± 0.53%)}	_{14.03s (± 0.39%)}	_~	_13.93s	_14.09s	_{p=1.000 n=6}
_{Bind Time}	_{4.42s (± 0.75%)}	_{4.44s (± 0.54%)}	_~	_4.42s	_4.48s	_{p=0.376 n=6}
_{Check Time}	_{87.99s (± 2.79%)}	_{87.15s (± 1.60%)}	_~	_85.06s	_88.25s	_{p=0.471 n=6}
_{Emit Time}	_{23.43s (± 7.58%)}	_{25.56s (± 8.90%)}	_~	_22.55s	_27.29s	_{p=0.471 n=6}
_{Total Time}	_{129.88s (± 2.37%)}	_{131.17s (± 2.77%)}	_~	_126.27s	_133.69s	_{p=0.298 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_285,172	_285,183	_{+11 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_115,780	_115,780	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{435,090k (± 0.02%)}	_{435,063k (± 0.02%)}	_~	_434,955k	_435,199k	_{p=0.687 n=6}
_{Parse Time}	_{4.06s (± 0.40%)}	_{4.03s (± 1.10%)}	_~	_3.96s	_4.08s	_{p=0.197 n=6}
_{Bind Time}	_{1.73s (± 1.24%)}	_{1.75s (± 1.59%)}	_~	_1.72s	_1.78s	_{p=0.293 n=6}
_{Check Time}	_{18.30s (± 0.48%)}	_{18.33s (± 0.53%)}	_~	_18.17s	_18.43s	_{p=0.521 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.08s (± 0.39%)}	_{24.11s (± 0.34%)}	_~	_24.02s	_24.23s	_{p=0.630 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_540,222	_540,239	_{+17 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_181,145	_181,145	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{483,845k (± 0.01%)}	_{483,902k (± 0.01%)}	_~	_483,856k	_483,957k	_{p=0.128 n=6}
_{Parse Time}	_{4.17s (± 0.67%)}	_{4.17s (± 0.59%)}	_~	_4.13s	_4.19s	_{p=0.804 n=6}
_{Bind Time}	_{1.46s (± 0.94%)}	_{1.46s (± 0.83%)}	_~	_1.44s	_1.47s	_{p=1.000 n=6}
_{Check Time}	_{23.71s (± 0.41%)}	_{23.66s (± 0.30%)}	_~	_23.59s	_23.78s	_{p=0.378 n=6}
_{Emit Time}	_{0.00s (±154.76%)}	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=0.595 n=6}
_{Total Time}	_{29.34s (± 0.38%)}	_{29.30s (± 0.26%)}	_~	_29.21s	_29.41s	_{p=0.688 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-10-08T19:21:13Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60142/merge:

Something interesting changed - please have a look.

Details

angular/angular-cli

8 of 24 projects failed to build with the old tsc and were ignored

tests/legacy-cli/tsconfig.json

error TS2416: Property 'forEach' in type 'DefinitionCollection<V>' is not assignable to the same property in base type 'ReadonlyMap<string, V>'.
- packages/angular_devkit/core/src/workspace/definitions.ts#L69

rbuckton · 2024-10-14T22:16:12Z

I'm not clear on why this is needed? ReadonlyMap is not an actual ECMAScript constructor and the interface could just as easily apply to any user-defined map-like objects. For example, this change would break DeoptExplorer:

Add well-known symbols for ReadonlyMap and ReadonlySet

d4a80a1

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Oct 5, 2024

milkcask mentioned this pull request Oct 7, 2024

Use string literal type in ArrayBuffer's Symbol.toStringTag #60149

Open

Add baselines

4bf9f75

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add well-known symbols for ReadonlyMap and ReadonlySet #60142

Add well-known symbols for ReadonlyMap and ReadonlySet #60142

milkcask commented Oct 5, 2024 •

edited

Loading

jakebailey commented Oct 8, 2024

typescript-bot commented Oct 8, 2024 •

edited

Loading

typescript-bot commented Oct 8, 2024

typescript-bot commented Oct 8, 2024

typescript-bot commented Oct 8, 2024

tsc

typescript-bot commented Oct 8, 2024

angular/angular-cli

tests/legacy-cli/tsconfig.json

rbuckton commented Oct 14, 2024

Add well-known symbols for ReadonlyMap and ReadonlySet #60142

Are you sure you want to change the base?

Add well-known symbols for ReadonlyMap and ReadonlySet #60142

Conversation

milkcask commented Oct 5, 2024 • edited Loading

jakebailey commented Oct 8, 2024

typescript-bot commented Oct 8, 2024 • edited Loading

typescript-bot commented Oct 8, 2024

typescript-bot commented Oct 8, 2024

typescript-bot commented Oct 8, 2024

tsc

typescript-bot commented Oct 8, 2024

angular/angular-cli

tests/legacy-cli/tsconfig.json

rbuckton commented Oct 14, 2024

milkcask commented Oct 5, 2024 •

edited

Loading

typescript-bot commented Oct 8, 2024 •

edited

Loading