Fix #61098 #61113

HansBrende · 2025-02-04T20:04:31Z

HansBrende · 2025-02-04T20:07:31Z

@microsoft-github-policy-service agree company="iMuto Software Solutions LLC"

RyanCavanaugh · 2025-02-07T16:38:25Z

typescript-bot · 2025-02-07T16:38:30Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-02-07T16:59:57Z

@RyanCavanaugh Here are the results of running the user tests with tsc comparing main and refs/pull/61113/merge:

Everything looks good!

typescript-bot · 2025-02-07T17:01:20Z

Hey @RyanCavanaugh, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-02-07T17:24:43Z

@RyanCavanaugh
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,390	_62,390	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,385k (± 1.00%)}	_{194,423k (± 1.02%)}	_~	_193,111k	_196,987k	_{p=0.575 n=6}
_{Parse Time}	_{1.31s (± 0.80%)}	_{1.31s (± 0.75%)}	_~	_1.30s	_1.33s	_{p=0.343 n=6}
_{Bind Time}	_0.73s	_0.73s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.75s (± 0.41%)}	_{9.79s (± 0.18%)}	_{+0.04s (+ 0.46%)}	_9.78s	_9.83s	_{p=0.020 n=6}
_{Emit Time}	_{2.73s (± 0.38%)}	_{2.73s (± 0.68%)}	_~	_2.71s	_2.76s	_{p=0.370 n=6}
_{Total Time}	_{14.51s (± 0.39%)}	_{14.57s (± 0.25%)}	_~	_14.54s	_14.63s	_{p=0.090 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,488	_948,488	_~	_~	_~	_{p=1.000 n=6}
_Types	_411,006	_411,006	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,225,460k (± 0.00%)}	_{1,225,454k (± 0.00%)}	_~	_1,225,358k	_1,225,535k	_{p=0.936 n=6}
_{Parse Time}	_{6.63s (± 1.12%)}	_{6.68s (± 0.45%)}	_~	_6.64s	_6.72s	_{p=0.375 n=6}
_{Bind Time}	_{1.89s (± 0.67%)}	_{1.88s (± 0.56%)}	_~	_1.87s	_1.90s	_{p=0.456 n=6}
_{Check Time}	_{31.92s (± 0.25%)}	_{31.99s (± 0.22%)}	_~	_31.89s	_32.07s	_{p=0.170 n=6}
_{Emit Time}	_{15.23s (± 0.54%)}	_{15.21s (± 0.50%)}	_~	_15.10s	_15.32s	_{p=0.521 n=6}
_{Total Time}	_{55.68s (± 0.14%)}	_{55.76s (± 0.24%)}	_~	_55.52s	_55.92s	_{p=0.229 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,372,446	_2,372,446	_~	_~	_~	_{p=1.000 n=6}
_Types	_846,261	_846,261	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,139,057k (± 0.00%)}	_{2,139,002k (± 0.00%)}	_~	_2,138,887k	_2,139,118k	_{p=0.470 n=6}
_{Parse Time}	_{7.27s (± 0.18%)}	_{7.27s (± 0.47%)}	_~	_7.23s	_7.33s	_{p=0.870 n=6}
_{Bind Time}	_{2.47s (± 0.91%)}	_{2.45s (± 0.36%)}	_{-0.02s (- 0.94%)}	_2.44s	_2.46s	_{p=0.040 n=6}
_{Check Time}	_{72.24s (± 1.44%)}	_{73.08s (± 0.52%)}	_~	_72.63s	_73.54s	_{p=0.092 n=6}
_{Emit Time}	_{0.15s (± 3.52%)}	_{0.15s (± 3.77%)}	_~	_0.14s	_0.15s	_{p=0.640 n=6}
_{Total Time}	_{82.13s (± 1.23%)}	_{82.95s (± 0.50%)}	_~	_82.47s	_83.48s	_{p=0.093 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,397	_1,229,400	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_267,085	_267,085	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,362,446k (± 0.02%)}	_{2,362,085k (± 0.02%)}	_~	_2,361,427k	_2,362,562k	_{p=0.230 n=6}
_{Parse Time}	_{5.23s (± 0.88%)}	_{5.26s (± 0.76%)}	_~	_5.21s	_5.31s	_{p=0.378 n=6}
_{Bind Time}	_{1.79s (± 1.10%)}	_{1.79s (± 0.61%)}	_~	_1.78s	_1.81s	_{p=0.619 n=6}
_{Check Time}	_{35.28s (± 0.24%)}	_{35.28s (± 0.33%)}	_~	_35.17s	_35.50s	_{p=0.335 n=6}
_{Emit Time}	_{3.03s (± 0.74%)}	_{3.00s (± 0.53%)}	_~	_2.98s	_3.02s	_{p=0.065 n=6}
_{Total Time}	_{45.33s (± 0.19%)}	_{45.32s (± 0.22%)}	_~	_45.24s	_45.50s	_{p=0.936 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,397	_1,229,400	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_267,085	_267,085	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,917,923k (±12.85%)}	_{2,553,190k (±11.64%)}	_~	_2,430,838k	_3,160,316k	_{p=0.066 n=6}
_{Parse Time}	_{6.98s (± 1.89%)}	_{6.88s (± 2.01%)}	_~	_6.75s	_7.14s	_{p=0.298 n=6}
_{Bind Time}	_{2.16s (± 0.99%)}	_{2.18s (± 1.49%)}	_~	_2.13s	_2.22s	_{p=0.126 n=6}
_{Check Time}	_{42.87s (± 0.57%)}	_{42.87s (± 0.55%)}	_~	_42.45s	_43.14s	_{p=0.810 n=6}
_{Emit Time}	_{3.49s (± 1.25%)}	_{3.56s (± 2.66%)}	_~	_3.44s	_3.68s	_{p=0.199 n=6}
_{Total Time}	_{55.49s (± 0.70%)}	_{55.48s (± 0.58%)}	_~	_55.05s	_55.85s	_{p=0.936 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_263,074	_263,077	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,881	_106,881	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{441,345k (± 0.01%)}	_{441,330k (± 0.02%)}	_~	_441,254k	_441,435k	_{p=0.689 n=6}
_{Parse Time}	_{3.55s (± 0.92%)}	_{3.52s (± 0.85%)}	_~	_3.48s	_3.55s	_{p=0.195 n=6}
_{Bind Time}	_{1.31s (± 0.79%)}	_{1.31s (± 1.08%)}	_~	_1.29s	_1.33s	_{p=0.738 n=6}
_{Check Time}	_{19.02s (± 0.41%)}	_{18.98s (± 0.52%)}	_~	_18.83s	_19.11s	_{p=0.521 n=6}
_{Emit Time}	_{1.52s (± 0.99%)}	_{1.52s (± 1.53%)}	_~	_1.49s	_1.55s	_{p=1.000 n=6}
_{Total Time}	_{25.39s (± 0.33%)}	_{25.33s (± 0.37%)}	_~	_25.21s	_25.48s	_{p=0.148 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,113	_226,113	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,783k (± 0.01%)}	_{371,836k (± 0.04%)}	_~	_371,714k	_372,036k	_{p=0.521 n=6}
_{Parse Time}	_{2.92s (± 0.56%)}	_{2.88s (± 0.81%)}	_{-0.03s (- 1.14%)}	_2.85s	_2.91s	_{p=0.043 n=6}
_{Bind Time}	_{1.60s (± 1.02%)}	_{1.59s (± 1.10%)}	_~	_1.56s	_1.61s	_{p=0.162 n=6}
_{Check Time}	_{16.43s (± 0.19%)}	_{16.45s (± 0.44%)}	_~	_16.35s	_16.56s	_{p=0.468 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.95s (± 0.24%)}	_{20.93s (± 0.45%)}	_~	_20.77s	_21.02s	_{p=0.936 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,285,568	_3,285,568	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,129,607	_1,129,607	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,357,302k (± 0.01%)}	_{3,357,442k (± 0.01%)}	_~	_3,357,057k	_3,357,874k	_{p=0.471 n=6}
_{Parse Time}	_{14.57s (± 0.43%)}	_{14.60s (± 0.34%)}	_~	_14.52s	_14.67s	_{p=0.375 n=6}
_{Bind Time}	_{4.65s (± 1.78%)}	_{4.67s (± 2.72%)}	_~	_4.56s	_4.92s	_{p=0.687 n=6}
_{Check Time}	_{91.39s (± 1.88%)}	_{89.09s (± 0.48%)}	_~	_88.38s	_89.69s	_{p=0.066 n=6}
_{Emit Time}	_{28.62s (± 3.18%)}	_{28.50s (± 3.59%)}	_~	_27.36s	_29.52s	_{p=0.575 n=6}
_{Total Time}	_{139.23s (± 0.96%)}	_{136.86s (± 0.95%)}	_{-2.37s (- 1.70%)}	_135.07s	_138.28s	_{p=0.020 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_293,381	_293,381	_~	_~	_~	_{p=1.000 n=6}
_Types	_119,582	_119,582	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{447,160k (± 0.02%)}	_{447,191k (± 0.02%)}	_~	_447,029k	_447,303k	_{p=0.521 n=6}
_{Parse Time}	_{4.10s (± 1.18%)}	_{4.08s (± 1.25%)}	_~	_4.01s	_4.14s	_{p=0.467 n=6}
_{Bind Time}	_{1.79s (± 0.91%)}	_{1.78s (± 0.66%)}	_~	_1.76s	_1.79s	_{p=0.462 n=6}
_{Check Time}	_{18.83s (± 0.45%)}	_{18.85s (± 0.50%)}	_~	_18.72s	_18.95s	_{p=0.810 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.72s (± 0.46%)}	_{24.71s (± 0.50%)}	_~	_24.51s	_24.80s	_{p=0.936 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_555,375	_555,375	_~	_~	_~	_{p=1.000 n=6}
_Types	_186,146	_186,146	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{494,483k (± 0.03%)}	_{494,440k (± 0.03%)}	_~	_494,254k	_494,667k	_{p=0.378 n=6}
_{Parse Time}	_{3.40s (± 0.64%)}	_{3.42s (± 0.86%)}	_~	_3.37s	_3.45s	_{p=0.259 n=6}
_{Bind Time}	_{1.19s (± 1.26%)}	_{1.19s (± 0.69%)}	_~	_1.17s	_1.19s	_{p=0.241 n=6}
_{Check Time}	_{19.68s (± 1.61%)}	_{19.83s (± 2.17%)}	_~	_19.53s	_20.57s	_{p=0.520 n=6}
_{Emit Time}	_0.00s	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=0.405 n=6}
_{Total Time}	_{24.28s (± 1.34%)}	_{24.44s (± 1.83%)}	_~	_24.13s	_25.19s	_{p=0.630 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-02-07T18:12:21Z

@RyanCavanaugh Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61113/merge:

Everything looks good!

Fix microsoft#61098

69acad2

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Feb 4, 2025

fix typo

ab62dc5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #61098 #61113

Fix #61098 #61113

HansBrende commented Feb 4, 2025

HansBrende commented Feb 4, 2025

RyanCavanaugh commented Feb 7, 2025

typescript-bot commented Feb 7, 2025 •

edited

Loading

typescript-bot commented Feb 7, 2025

typescript-bot commented Feb 7, 2025

typescript-bot commented Feb 7, 2025

tsc

typescript-bot commented Feb 7, 2025

Fix #61098 #61113

Are you sure you want to change the base?

Fix #61098 #61113

Conversation

HansBrende commented Feb 4, 2025

HansBrende commented Feb 4, 2025

RyanCavanaugh commented Feb 7, 2025

typescript-bot commented Feb 7, 2025 • edited Loading

typescript-bot commented Feb 7, 2025

typescript-bot commented Feb 7, 2025

typescript-bot commented Feb 7, 2025

tsc

typescript-bot commented Feb 7, 2025

typescript-bot commented Feb 7, 2025 •

edited

Loading