-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Add] Function calling support for Autobuild #2294
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2294 +/- ##
===========================================
- Coverage 38.14% 26.53% -11.62%
===========================================
Files 78 81 +3
Lines 7865 8134 +269
Branches 1683 1876 +193
===========================================
- Hits 3000 2158 -842
- Misses 4615 5725 +1110
- Partials 250 251 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@microsoft-github-policy-service agree |
You can fix code formatting running |
@krishnashed, I'd like to explore and validate any test scenarios you might have. Thanks. |
hey @krishnashed very nice feature, could you check this feature and make it compatible? https://microsoft.github.io/autogen/docs/topics/code-execution/user-defined-functions/ |
Sure @JieyuZ2 I'll check it out and make sure it's compatible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sonichi Closing the review, as minor update you suggested is implemented, and pre-build checks are now passing
@jamesliu I have added test cases for Autobuild function calling, can you please review? |
@@ -642,13 +686,58 @@ def _build_agents( | |||
|
|||
Returns: | |||
agent_list: a list of agents. | |||
list_of_functions: List of functions to be registered with agents. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
list_of_functions in Args, not in Returns
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
10404662 | Triggered | Generic CLI Secret | b522480 | .github/workflows/dotnet-release.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Why are these changes needed?
Introduction of Autobuild, didn't support function/tool calling. This PR is solution to add this feature/
Related issue number
Closes #1510
Checks
Check and tests still need to be written and passed.