Dotnet Grpc worker implementation #5245
Open
+1,786
−210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lokitoth
force-pushed
the
grpc_dotnet_worker
branch
from
1b9ad7a to
ff2b423
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5245 +/- ##
=======================================
Coverage 76.02% 76.02%
=======================================
Files 157 157
Lines 9491 9491
=======================================
Hits 7216 7216
Misses 2275 2275
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rysweet
reviewed
Jan 31, 2025
There was a problem hiding this comment.
I think that most of the changes to the server side aren't necessary - I would just bring back the files from the old core that it was depending upon to start with and get the client talking to it. It was working xlang e2e (ie with the python client) on Monday am
* Define skeleton for GrpcAgentRuntime * Implement CloudEvent and RPC Payload serialization/marshaling
* Factor out AgentContainer for managing factory registration, instantiation, and subscription management
* Prefer AgentsAppBuilderExtensions as name, due to matching the incoming `this` type.
jackgerrits
force-pushed
the
grpc_dotnet_worker
branch
from
100e9e0 to
7c3c934
Compare
|
Yep - scoped this back to the worker only |
rysweet
reviewed
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.