Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gemini model families, enhance group chat selection for Gemini model and add tests #5334

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

ekzhu
Copy link
Collaborator

@ekzhu ekzhu commented Feb 3, 2025

Resolves #5322

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.02%. Comparing base (9af6883) to head (3649818).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...gentchat/teams/_group_chat/_selector_group_chat.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5334   +/-   ##
=======================================
  Coverage   76.02%   76.02%           
=======================================
  Files         157      157           
  Lines        9483     9488    +5     
=======================================
+ Hits         7209     7213    +4     
- Misses       2274     2275    +1     
Flag Coverage Δ
unittests 76.02% <87.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekzhu ekzhu enabled auto-merge (squash) February 3, 2025 18:28
@ekzhu ekzhu merged commit 569bc19 into main Feb 3, 2025
62 checks passed
@ekzhu ekzhu deleted the ekzhu-add-gemini-model-family branch February 3, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SelectorGroupChat not working with Gemini 2.0 Flash
2 participants