Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proto descriptor for typename #5346

Merged
merged 5 commits into from
Feb 4, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,13 @@ class UnknownPayload:


def _type_name(cls: type[Any] | Any) -> str:
# If cls is a protobuf, then we need to determine the descriptor
if isinstance(cls, type):
if issubclass(cls, Message):
return cast(str, cls.DESCRIPTOR.full_name)
elif isinstance(cls, Message):
return cast(str, cls.DESCRIPTOR.full_name)

if isinstance(cls, type):
return cls.__name__
else:
Expand Down
16 changes: 15 additions & 1 deletion python/packages/autogen-core/tests/test_serialization.py
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def test_proto() -> None:
message = ProtoMessage(message="hello")
name = serde.type_name(message)
data = serde.serialize(message, type_name=name, data_content_type=PROTOBUF_DATA_CONTENT_TYPE)
assert name == "ProtoMessage"
assert name == "agents.ProtoMessage"
deserialized = serde.deserialize(data, type_name=name, data_content_type=PROTOBUF_DATA_CONTENT_TYPE)
assert deserialized.message == message.message

Expand Down Expand Up @@ -186,3 +186,17 @@ class PydanticImageMessage(BaseModel):
assert deserialized.image.image.size == (100, 100)
assert deserialized.image.image.mode == "RGB"
assert deserialized.image.image == image.image


def test_type_name_for_protos() -> None:
type_name = SerializationRegistry().type_name(ProtoMessage())
assert type_name == "agents.ProtoMessage"

type_name = SerializationRegistry().type_name(ProtoMessage)
assert type_name == "agents.ProtoMessage"

type_name = SerializationRegistry().type_name(NestingProtoMessage())
assert type_name == "agents.NestingProtoMessage"

type_name = SerializationRegistry().type_name(NestingProtoMessage)
assert type_name == "agents.NestingProtoMessage"
Loading