Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User/jocelynb/add fwupd spec #11971

Open
wants to merge 1 commit into
base: 3.0-dev
Choose a base branch
from

Conversation

JocelynBerrendonner
Copy link
Member

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
The PR introduce the fwupd package and its dependencies to the SPECS-EXTENDED folder (all the code is contained within SPECS-EXTENDED). Package definitions were pulled from the Fedora repository and subsequently modified to match the Azure Linux requirements. The source code was pulled from the Fedora servers.

Change Log

New Packages:

Package Upgrades:

  • SPECS-EXTENDED/libblockdev/libblockdev.spec
    - spec config change
  • SPECS-EXTENDED/libjcat/libjcat.spec
    - 0.1.6 to 0.2.2
  • SPECS-EXTENDED/libxmlb/libxmlb.spec
    - 0.3.11 to 0.3.21
Does this affect the toolchain?

NO

Associated issues

n/a

Links to CVEs

n/a

Test Methodology
  • Locally built and manually tested the resulting binary on a test box.

@JocelynBerrendonner JocelynBerrendonner requested a review from a team as a code owner January 17, 2025 01:47
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging specs-extended PR to fix SPECS-EXTENDED 3.0-dev PRs Destined for AzureLinux 3.0 labels Jan 17, 2025
@JocelynBerrendonner JocelynBerrendonner requested a review from a team as a code owner January 23, 2025 21:01
@JocelynBerrendonner JocelynBerrendonner force-pushed the user/jocelynb/add_fwupd_spec branch from 1f00b19 to a9956b0 Compare January 23, 2025 21:28
@JocelynBerrendonner JocelynBerrendonner requested a review from a team as a code owner January 23, 2025 21:28
@microsoft-github-policy-service microsoft-github-policy-service bot added documentation Improvements or additions to documentation Tools Schema Changes to image configurations labels Jan 23, 2025
@JocelynBerrendonner JocelynBerrendonner force-pushed the user/jocelynb/add_fwupd_spec branch 2 times, most recently from 3ed479e to 363c464 Compare January 24, 2025 17:25
@bfjelds
Copy link
Member

bfjelds commented Jan 29, 2025

  • i think the version-iteration of new packages should match the upstream version being imported, seems inconsistent in the PR. there are some that use the same version (i think this is correct), some that increment the version.

  • ensure that the changelog version matches what is declared in the spec.

  • i think that only downloaded files need to be in the signature file, so patch files that are in the PR don't need to be included.

@JocelynBerrendonner
Copy link
Member Author

JocelynBerrendonner commented Jan 29, 2025

  • i think the version-iteration of new packages should match the upstream version being imported, seems inconsistent in the PR. there are some that use the same version (i think this is correct), some that increment the version.
  • ensure that the changelog version matches what is declared in the spec.
  • i think that only downloaded files need to be in the signature file, so patch files that are in the PR don't need to be included.

Thanks for the great feedback. What I understand from the build team is:

  • As per Andrew's guidance, the version and release numbers in the Azure Linux spec file need to be increased by one when pulling/adapting a spec from Fedora (so, there is some revv'ing up of these numbers)
  • You are correct about not having patch files as part of the signature file. To clarify, as per the build team, all the files mentioned as "Sources" in the spec file must have their signature in the signature json file. Other files don't.

@JocelynBerrendonner JocelynBerrendonner force-pushed the user/jocelynb/add_fwupd_spec branch 3 times, most recently from 10b08c0 to 9abce47 Compare January 29, 2025 20:49
@JocelynBerrendonner JocelynBerrendonner force-pushed the user/jocelynb/add_fwupd_spec branch 2 times, most recently from ef94aa9 to 4ef7ae7 Compare January 30, 2025 01:38
@JocelynBerrendonner JocelynBerrendonner force-pushed the user/jocelynb/add_fwupd_spec branch from f3d7ce8 to 0ffb68f Compare January 30, 2025 02:34
@JocelynBerrendonner JocelynBerrendonner force-pushed the user/jocelynb/add_fwupd_spec branch from 0ffb68f to 2243303 Compare January 30, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 documentation Improvements or additions to documentation Packaging Schema Changes to image configurations specs-extended PR to fix SPECS-EXTENDED Tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants