Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 1.7.7 with newer golang/x/net for CVE-2023-39325 and CVE-2023-44487 #12125

Closed
wants to merge 10 commits into from

Conversation

gjswalling
Copy link
Contributor

@gjswalling gjswalling commented Jan 29, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Upgrade application-gateway-kubernetes-ingress to 1.7.7 with golang/x/net 0.33.0 for CVE-2023-39325 and CVE-2023-44487

Change Log
  • Upgrade main package and golang/x/net
Does this affect the toolchain?

NO

Links to CVEs
Test Methodology
  • Pipeline build id: 724988

@osamaesmailmsft
Copy link
Contributor

I noticed that SPECS/application-gateway-kubernetes-ingress/application-gateway-kubernetes-ingress.signatures.json hasn't been updated.

@gjswalling gjswalling marked this pull request as ready for review January 30, 2025 22:18
@gjswalling gjswalling requested a review from a team as a code owner January 30, 2025 22:18
@gjswalling gjswalling changed the title Upgrade golang/x/net for CVE-2023-39325 and CVE-2023-44487 Upgrade to 1.7.7 with newer golang/x/net for CVE-2023-39325 and CVE-2023-44487 Jan 31, 2025
@gjswalling
Copy link
Contributor Author

@@ -59,6 +43,10 @@ cp appgw-ingress %{buildroot}%{_bindir}/
%{_bindir}/appgw-ingress

%changelog
* Fri Jan 31 2025 Gary Swalling <gaswal@@microsoft.com> - 1.7.7-1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix this before merging

@gjswalling gjswalling closed this Feb 5, 2025
@gjswalling gjswalling deleted the gaswal/app-gw-cve branch February 5, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants