Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fear: bumped ts version and added check for .d.ts files #828

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

saurav0705
Copy link
Contributor

@saurav0705 saurav0705 commented Jul 13, 2023

Features

  1. Bumped ts version to 5.1.6
  2. Added CI check for declaration file check
  3. Added a script to check before releasing to npm npm run check:release

NOTE: Please include the command npm run check:release in your npm release workflow as this will check for declaration files

@saurav0705 saurav0705 requested a review from a team as a code owner July 13, 2023 10:11
@saurav0705 saurav0705 changed the title chore: bumped ts version fear: bumped ts version and added check for .d.ts files Oct 30, 2023
@velimir-jankovic
Copy link

We don't want to modify GitHub pipeline, but check if definition files are created properly during build:release won't hurt. Please remove changes from yml file.

#827 (comment)

@velimir-jankovic velimir-jankovic requested review from velimirj and removed request for velimirj November 8, 2023 12:51
@velimir-jankovic velimir-jankovic merged commit c6815bf into microsoft:master Nov 8, 2023
2 checks passed
@saurav0705 saurav0705 deleted the chore/ts-version-bump branch November 9, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants