-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes 'pattern' mode on mac #298
base: main
Are you sure you want to change the base?
Conversation
@skaparelos please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
The issue has to do with accessing
vscode.window.activeTextEditor?.document
Probably something changed in vscode since that part was written and
activeTextEditor
returns the codeTour textbox that the comment is being written. Therefore, this crashes for any file where we try to access a line number bigger than the few lines the textbox has.This PR gets one way to access the right editor