You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think Uninstall-Containerd is doing more than needed. I suggest we only uninstall what we install, but not touch the installations in $env:GOPATH/bin.
PS C:\> Uninstall-Containerd
Confirm
Are you sure you want to perform this action?
Performing the operation "Containerd will be uninstalled from C:\Users\uname\go and containerd service will be stopped and unregistered" on target
"CPC-unam-6MIB0".
[Y] Yes [A] Yes to All [N] No [L] No to All [S] Suspend [?] Help (default is "Y"): Y
Are you sure you want to uninstall Containerd?
C:\Users\uname\go
[Y] Yes [N] No [S] Suspend [?] Help (default is "Y"): Y
WARNING: Uninstalling preinstalled Containerd at the path C:\Users\uname\go
Remove-Item: The process cannot access the file 'C:\Users\uname\go\bin\containerd-shim-runhcs-v1.exe' because it is being used by another process.
Remove-Item: Access to the path 'C:\Users\uname\go\bin\dlv.exe' is denied.
Remove-Item: The directory is not empty. : 'C:\Users\uname\go\bin'
To Reproduce
Detailed steps to reproduce the behavior:
Have other own custom containerd installation in $env:GOPATH/bin
Run Uninstall-Containerd
The more information you can provide, the more likely someone will be successful at triaging and reproducing the issue and finding a fix.
Expected behavior
Uninstall only containerd stuff in $env:ProgramFiles\containerd. (together with all CNI, perhaps the user needs to be told that too since we have: Install-WinCNIPlugin that puts stuff in that directory too)
The text was updated successfully, but these errors were encountered:
That's why we ask the user to confirm before uninstallation. We could skip the uninstall instead and proceed with installation of the new version. However, if the user does not specify the path to install the new version, it will overwrite the existing version
It finds the location of the command e.g containerd using Get-Command and returns the first location. The 'Uninstall-Command` has the option to provide the location of the binaries.
Describe the bug
I think
Uninstall-Containerd
is doing more than needed. I suggest we only uninstall what we install, but not touch the installations in$env:GOPATH/bin
.To Reproduce
Detailed steps to reproduce the behavior:
containerd
installation in$env:GOPATH/bin
Uninstall-Containerd
The more information you can provide, the more likely someone will be successful at triaging and reproducing the issue and finding a fix.
Expected behavior
Uninstall only
containerd
stuff in$env:ProgramFiles\containerd
. (together with all CNI, perhaps the user needs to be told that too since we have:Install-WinCNIPlugin
that puts stuff in that directory too)The text was updated successfully, but these errors were encountered: