Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Refactor the uninstall commands to only remove program data (program data folder, config files, env variable, and RegKeys) when the
-purge
flag is passed.Github issue
Uninstall-Containerd too destructive #40
Background information
Running the uninstall command currently deletes the program data as well. This is too destructive as the user would like to retain these folders/files (e.g. Containerd snapshot folder) even after installing another version (either an upgrade or an upgrade).
To resolve this, we add a
-purge
flag that when passed in the uninstall command, the program data will be removed, otherwise, it will be retained.Testing information
Examples: To uninstall containerd
WhatIf
Retain the program data
Uninstall-Containerd
Purge program data
Checklist
As part of our commitment to engineering excellence, before submitting this PR, please make sure:
In addition, after this PR has been reviewed, please agree to: