Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a11y insights #57

Merged
merged 35 commits into from
Jan 23, 2025
Merged

Fix a11y insights #57

merged 35 commits into from
Jan 23, 2025

Conversation

danmarshall
Copy link
Collaborator

No description provided.

@danmarshall danmarshall marked this pull request as draft January 7, 2025 23:04
@danmarshall danmarshall marked this pull request as ready for review January 10, 2025 23:01

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 17 changed files in this pull request and generated no comments.

Files not reviewed (12)
  • .vscode/launch.json: Language not supported
  • src/scss/App.scss: Language not supported
  • src/scss/DataView.scss: Language not supported
  • src/scss/EncodingShelf.scss: Language not supported
  • src/views/ReactTable.tsx: Evaluated as low risk
  • src/views/EncodingShelfThread.tsx: Evaluated as low risk
  • src/views/VisualizationView.tsx: Evaluated as low risk
  • src/views/EncodingBox.tsx: Evaluated as low risk
  • src/views/TableSelectionView.tsx: Evaluated as low risk
  • src/views/ConceptCard.tsx: Evaluated as low risk
  • src/views/DataThread.tsx: Evaluated as low risk
  • src/views/SelectableDataGrid.tsx: Evaluated as low risk
Comments suppressed due to low confidence (2)

src/views/ModelSelectionDialog.tsx:314

  • The error message color is hardcoded. Use a theme color instead for consistency. For example, use color="error".
<Typography variant="caption" color="#c82c2c">

src/views/DataView.tsx:113

  • Using a hardcoded color value is not recommended. It should use the theme's color system for consistency. Replace color="#1770c7" with color="primary".
color="#1770c7" onClick={()=>{ dispatch(dfActions.setFocusedTable(t.id)) }}
@danmarshall danmarshall merged commit c065bdf into main Jan 23, 2025
6 checks passed
@danmarshall danmarshall deleted the a11y-insights branch January 23, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant