Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Dave Thaler <[email protected]>
  • Loading branch information
Alan-Jowett and dthaler authored Oct 10, 2024
1 parent af048fb commit 7b69f08
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
3 changes: 2 additions & 1 deletion libs/runtime/ebpf_epoch.c
Original file line number Diff line number Diff line change
Expand Up @@ -1182,7 +1182,8 @@ _IRQL_requires_(DISPATCH_LEVEL) static void _ebpf_epoch_deactivate_cpu(uint32_t
{
EBPF_LOG_ENTRY();
ebpf_assert(cpu_id == ebpf_get_current_cpu());
// Deactivate the CPU 0 is not allowed.

// Deactivating CPU 0 is not allowed.
ebpf_assert(cpu_id != 0);
ebpf_assert(ebpf_list_is_empty(&_ebpf_epoch_cpu_table[cpu_id].epoch_state_list));
ebpf_assert(ebpf_list_is_empty(&_ebpf_epoch_cpu_table[cpu_id].free_list));
Expand Down
1 change: 0 additions & 1 deletion libs/runtime/unit/platform_unit_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -673,7 +673,6 @@ _run_epoch_test_script(const std::vector<std::string>& script)
test_helper.initialize();
// Add scope to ensure that epoch state is cleaned up before test_helper.
{

std::vector<work_item_context_t> work_item_contexts(2);
std::vector<ebpf_epoch_scope_t> epoch_states = {false, false};
std::vector<work_item_ptr> work_items;
Expand Down

0 comments on commit 7b69f08

Please sign in to comment.