chore: update test suites to leverage @web/test-runner and esm supported libraries #6847

chrisdholt · 2023-09-30T09:57:54Z

Pull Request

📖 Description

This PR updates testing across the repo to leverage @web/test-runner. This is a necessary step to update TypeScript.

🎫 Issues

n/a

packages/web-components/fast-element/src/templating/repeat.spec.ts

radium-v · 2023-11-08T16:23:57Z

.github/workflows/ci-validate-platforms.yml

-        run: |
-          yarn playwright install-deps
-          yarn playwright install
+        run: npx playwright install --with-deps


This has been a pain point for a while now - we're mixing NPM and Yarn across the repo and it's possible that this could result in conflicts since we're all using yarn locally, but the CI is using NPM. It makes it more complicated to debug when something goes wrong on the pipeline.

We should either be using only Yarn everywhere or only NPM everywhere, not both.

radium-v · 2023-11-08T16:28:15Z

packages/utilities/fast-colors/package.json

@@ -37,9 +37,8 @@
    "watch": "yarn build -- -w --preserveWatchOutput"
  },
  "devDependencies": {
-    "@types/chai": "^4.2.11",
+    "@esm-bundle/chai": "4.3.4-fix.0",


This is a weird nonstandard version of a package that hasn't been published in over a year:

esm-bundle/chai#280
esm-bundle/chai#315

radium-v · 2023-11-08T16:31:20Z

packages/utilities/fast-colors/src/color-blending.spec.ts

@@ -1,4 +1,4 @@
-import chai from "chai";
+import { expect } from "@esm-bundle/chai";


Chai version 5 is currently in alpha but is rewritten to only support ESM. Will we go back to Chai proper once it's stable?

https://github.com/chaijs/chai/releases/tag/v5.0.0-alpha.2

radium-v · 2023-11-08T16:38:37Z

packages/utilities/fast-react-wrapper/package.json

-    "test-chrome:verbose:debugger": "karma start karma.conf.cjs --browsers=ChromeDebugging --reporter=mocha",
-    "test-firefox": "karma start karma.conf.cjs --browsers=FirefoxHeadless --single-run --coverage",
-    "test-firefox:verbose": "karma start karma.conf.cjs --browsers=FirefoxHeadless --single-run --coverage --reporter=mocha"
+    "test": "yarn eslint && yarn build:tsc && web-test-runner && yarn doc:ci"


This script is run like a shell command - yarn takes care of it but other package managers might not in the future.

If we were to handle the transition from Yarn to NPM with a find/replace, it may turn into this:

$ npm run eslint $ npm run build:tsc $ web-test-runner # <-- this would break since `web-test-runner` isn't a direct command $ npm run doc:ci

Alternatively, this could be handled with pretest and posttest scripts:

"pretest": "yarn eslint && yarn build:tsc", "test": "web-test-runner", "posttest": "yarn doc:ci"

radium-v · 2023-11-08T16:50:54Z

packages/web-components/fast-element/src/components/element-controller.spec.ts

@@ -461,7 +459,7 @@ describe("The ElementController", () => {
            controller.connect();
            controller.disconnect();

-            expect(behavior.child.disconnectedCallback).to.have.been.called();
+            behavior.child.disconnectedCallback.called;


Shouldn't this statement value be asserted?

radium-v · 2023-11-08T17:19:15Z

packages/web-components/fast-foundation/src/radio/radio.pw.spec.ts

@@ -90,7 +90,7 @@ test.describe("Radio", () => {
            `;
        });

-        await expect(element).toHaveAttribute("tabindex", "");
+        await expect(element).not.toHaveAttribute("tabindex", "");


Playwright's toHaveAttribute doesn't properly handle the difference between a present attribute with a blank value (tabindex="") versus the non-existence of an attribute. This would be better expressed with hasAttribute:

await expect(element).not.hasAttribute("tabindex");

…meout in router tests

radium-v · 2023-11-14T03:21:30Z

@playwright/test should be upgradeable to the latest version (currently ^1.39.0) if yarn-deduplicate is used on the lockfile, to merge the different versions being pulled in.

(note: in my testing, @microsoft/fast-ssr will require locking [email protected] after using yarn-deduplicate!)

radium-v · 2023-11-14T03:25:43Z

When running all repo tests in streaming mode (yarn lerna run test --stream), there's a chance that runners will collide when trying to utilize port 8000. It's an intermittent failure which sometimes appears in parallel mode.

janechu · 2024-05-30T19:21:53Z

Closing this as it has many conflicts and has been out of date for some time, additionally this will be resolved in a future PR after we remove yarn and switch to npm.

chrisdholt requested review from EisenbergEffect and nicholasrice as code owners September 30, 2023 09:57

chrisdholt force-pushed the users/chhol/convert-karma-tests-to-web-test-runner branch from e6638a6 to 1e9916f Compare September 30, 2023 10:01

chrisdholt requested a review from awentzel as a code owner September 30, 2023 10:15

chrisdholt force-pushed the users/chhol/convert-karma-tests-to-web-test-runner branch 6 times, most recently from 94e3525 to 8bfdb06 Compare October 1, 2023 00:58

chrisdholt force-pushed the users/chhol/convert-karma-tests-to-web-test-runner branch from 8bfdb06 to 39c0191 Compare October 11, 2023 20:40

bheston approved these changes Oct 12, 2023

View reviewed changes

radium-v reviewed Nov 7, 2023

View reviewed changes

packages/web-components/fast-element/src/templating/repeat.spec.ts Outdated Show resolved Hide resolved

radium-v mentioned this pull request Nov 8, 2023

fix: RtlScrollConverter test on high dpi systems in fast-web-utilities #6857

Merged

5 tasks

KingOfTac approved these changes Nov 8, 2023

View reviewed changes

radium-v reviewed Nov 8, 2023

View reviewed changes

chrisdholt force-pushed the users/chhol/convert-karma-tests-to-web-test-runner branch from 39c0191 to de59c54 Compare November 8, 2023 18:28

chrisdholt added 13 commits November 8, 2023 11:30

initial update to use web-test-runner

727fa64

update fast-element to use sinon spies

acb1ea6

update fast-foundation deps

577ab9b

update web utilities

ffec139

setup tests for react-wrapper

9a69de3

update router testing

89c4ea5

update fast-colors tests

8dab586

cleanup

255b309

Change files

30a36ec

workflow updates for playwright

1a52a25

update playwright version

cf8bf72

fixup playwright tests based on latest assertions

b107a5a

Change files

b9c4c69

chrisdholt added 2 commits November 8, 2023 11:30

run chromium only for everything but foundation

c6121e5

await repeat tests, fix incorrect import in router, attempt longer ti…

3ccdd58

…meout in router tests

chrisdholt force-pushed the users/chhol/convert-karma-tests-to-web-test-runner branch from de59c54 to 3ccdd58 Compare November 8, 2023 19:31

radium-v mentioned this pull request Nov 14, 2023

[users/chhol/convert-karma-tests-to-web-test-runner] Upgrade Playwright to ^1.39.0 #6863

Closed

janechu closed this May 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update test suites to leverage @web/test-runner and esm supported libraries #6847

chore: update test suites to leverage @web/test-runner and esm supported libraries #6847

chrisdholt commented Sep 30, 2023

radium-v Nov 8, 2023

radium-v Nov 8, 2023

radium-v Nov 8, 2023

radium-v Nov 8, 2023

radium-v Nov 8, 2023

radium-v Nov 8, 2023

radium-v Nov 8, 2023

radium-v commented Nov 14, 2023

radium-v commented Nov 14, 2023

janechu commented May 30, 2024

		@@ -1,4 +1,4 @@
		import chai from "chai";
		import { expect } from "@esm-bundle/chai";

chore: update test suites to leverage @web/test-runner and esm supported libraries #6847

chore: update test suites to leverage @web/test-runner and esm supported libraries #6847

Conversation

chrisdholt commented Sep 30, 2023

Pull Request

📖 Description

🎫 Issues

radium-v Nov 8, 2023

Choose a reason for hiding this comment

radium-v Nov 8, 2023

Choose a reason for hiding this comment

radium-v Nov 8, 2023

Choose a reason for hiding this comment

radium-v Nov 8, 2023

Choose a reason for hiding this comment

radium-v Nov 8, 2023

Choose a reason for hiding this comment

radium-v Nov 8, 2023

Choose a reason for hiding this comment

radium-v Nov 8, 2023

Choose a reason for hiding this comment

radium-v commented Nov 14, 2023

radium-v commented Nov 14, 2023

janechu commented May 30, 2024