Add additional design token test cases and test fixes #6883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-akinc
requested review from
EisenbergEffect,
chrisdholt,
bheston,
scomea,
radium-v,
KingOfTac and
nicholasrice
as code owners
3 tasks
scomea
approved these changes
Jan 2, 2024
bheston
approved these changes
Jan 3, 2024
radium-v
force-pushed
the
fix-design-token-inheritance-bug-master
branch
from
62e4231 to
be7be5c
Compare
radium-v
changed the title
5 tasks
janechu
pushed a commit
that referenced
this pull request
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
PR #6879 addresses a design token inheritance issue in the
fast-element-1legacy branch. The issue does not exist in themasterbranch, but we would like to submit a few new test cases (the same ones being added to the legacy branch) to ensure no future regressions.Additionally, a couple existing tests are modified to better adhere to the apparent intents of the tests.
🎫 Issues
#6864
✅ Checklist
General
$ yarn change