Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove inline styling logic from DataGrid #6886

Closed
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "change DataGridRow.updateRowStyle to protected member from private property",
"packageName": "@microsoft/fast-foundation",
"email": "[email protected]",
"dependentChangeType": "prerelease"
}
2 changes: 2 additions & 0 deletions packages/web-components/fast-foundation/docs/api-report.md
Original file line number Diff line number Diff line change
Expand Up @@ -1107,6 +1107,8 @@ export class FASTDataGridRow extends FASTElement {
slottedCellElements: HTMLElement[];
// Warning: (ae-forgotten-export) The symbol "DataGridSelectionChangeDetail" needs to be exported by the entry point index.d.ts
toggleSelected(detail: DataGridSelectionChangeDetail): void;
// (undocumented)
protected updateRowStyle(): void;
}

// @public
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ export const myDataGrid = DataGrid.compose({
| `rowDataChanged` | protected | | | `void` | |
| `toggleSelected` | public | Attempts to set the selected state of the row | `detail: DataGridSelectionChangeDetail` | `void` | |
| `handleFocusout` | public | | `e: FocusEvent` | `void` | |
| `updateRowStyle` | protected | | | `void` | |

#### Events

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ export class FASTDataGridRow extends FASTElement {
: this.defaultHeaderCellItemTemplate;
}

private updateRowStyle = (): void => {
protected updateRowStyle(): void {
KingOfTac marked this conversation as resolved.
Show resolved Hide resolved
this.style.gridTemplateColumns = this.gridTemplateColumns;
};
}
}
Loading