Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foundation: Update standard template naming #6922

Closed
wants to merge 2 commits into from

Conversation

bheston
Copy link
Collaborator

@bheston bheston commented Mar 10, 2024

Pull Request

📖 Description

As part of the next major release of fast-foundation, we wanted to do a complete review of the component templates and align the structure and naming as much as possible.

This PR unifies the naming and cleans up some test styles, especially around the recent update to the start and end slots.

Before on the left, update on the right. "C" = class, "P" = part, "R" = role, "S" = slot. 💔 = potentially style-breaking.

Dialog

  • 💔 Flatten "positioning-region" element to host

Dialog

Radio group

  • 💔 Rename “positioning-region” to “control”
  • 💔 Remove “horizontal” or “vertical” class, use attribute on host instead

Radio group

Tab

  • Wrap default slot in “content”

Tab

Toolbar

  • 💔 Rename “positioning-region” to “control”

Toolbar

👩‍💻 Reviewer Notes

Review the Storybook site, or the illustrations of the components before and after, compared to the changes in code.

📑 Test Plan

Tested via comparison against proposal and in Storybook.

✅ Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

@janechu
Copy link
Collaborator

janechu commented Jun 14, 2024

Closing this as it seems like these changes will break user styling downstream.

@janechu janechu closed this Jun 14, 2024
@janechu janechu deleted the users/bheston/foundation-standard-names branch June 14, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants