Change missing input params to RequestNotValid (#4439)

Throw bad request for missing/invalid Parameters resource on $reindex call Refs AB#124925
microsoft · Aug 23, 2024 · 76698e7 · 76698e7
1 parent c21e635
commit 76698e7
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/src/Microsoft.Health.Fhir.Api/Features/Filters/ValidateParametersResourceAttribute.cs b/src/Microsoft.Health.Fhir.Api/Features/Filters/ValidateParametersResourceAttribute.cs
@@ -25,7 +25,7 @@ public override void OnActionExecuting(ActionExecutingContext context)
             context.ActionArguments?.TryGetValue("inputParams", out inputResource);
             if (inputResource == null)
             {
-                throw new MissingMethodException("Controller method does not contain parameter named 'inputParams'");
+                throw new RequestNotValidException(Resources.MissingInputParams);
             }
 
             if (inputResource is not Parameters)

diff --git a/src/Microsoft.Health.Fhir.Api/Resources.Designer.cs b/src/Microsoft.Health.Fhir.Api/Resources.Designer.cs
diff --git a/src/Microsoft.Health.Fhir.Api/Resources.resx b/src/Microsoft.Health.Fhir.Api/Resources.resx
@@ -423,4 +423,7 @@
   <data name="NotAbleToCreateTheFinalResultsOfAnOperation" xml:space="preserve">
     <value>Not able to create final result. Retry the operation.</value>
   </data>
+  <data name="MissingInputParams" xml:space="preserve">
+    <value>inputParams not found, request body must be a valid Parameters resource.</value>
+  </data>
 </root>