-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carousel: Stable Release #32883
Open
Mitch-At-Work
wants to merge
8
commits into
microsoft:master
Choose a base branch
from
Mitch-At-Work:user/mifraser/stable-carousel
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Carousel: Stable Release #32883
Mitch-At-Work
wants to merge
8
commits into
microsoft:master
from
Mitch-At-Work:user/mifraser/stable-carousel
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabricteam
reviewed
Sep 20, 2024
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 647 | 662 | 5000 | |
Button | mount | 307 | 318 | 5000 | |
Field | mount | 1149 | 1165 | 5000 | |
FluentProvider | mount | 742 | 749 | 5000 | |
FluentProviderWithTheme | mount | 105 | 91 | 10 | |
FluentProviderWithTheme | virtual-rerender | 37 | 42 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 89 | 101 | 10 | |
MakeStyles | mount | 856 | 883 | 50000 | |
Persona | mount | 1836 | 1771 | 5000 | |
SpinButton | mount | 1463 | 1473 | 5000 | |
SwatchPicker | mount | 1711 | 1717 | 5000 |
🕵 FluentUIV0 No visual regressions between this PR and main |
Perf Analysis (
|
Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
---|---|---|---|---|
AttachmentMinimalPerf.default | 84 | 83 | 1.01:1 | analysis |
Perf tests with no regressions
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
ButtonMinimalPerf.default | 98 | 78 | 1.26:1 |
ProviderMinimalPerf.default | 227 | 201 | 1.13:1 |
AvatarMinimalPerf.default | 117 | 106 | 1.1:1 |
DividerMinimalPerf.default | 211 | 196 | 1.08:1 |
SkeletonMinimalPerf.default | 210 | 195 | 1.08:1 |
CarouselMinimalPerf.default | 267 | 249 | 1.07:1 |
TreeWith60ListItems.default | 88 | 82 | 1.07:1 |
AnimationMinimalPerf.default | 314 | 297 | 1.06:1 |
ButtonSlotsPerf.default | 329 | 311 | 1.06:1 |
AttachmentSlotsPerf.default | 645 | 612 | 1.05:1 |
CardMinimalPerf.default | 311 | 297 | 1.05:1 |
LabelMinimalPerf.default | 226 | 215 | 1.05:1 |
LayoutMinimalPerf.default | 205 | 195 | 1.05:1 |
ReactionMinimalPerf.default | 216 | 206 | 1.05:1 |
AlertMinimalPerf.default | 164 | 157 | 1.04:1 |
DropdownManyItemsPerf.default | 404 | 387 | 1.04:1 |
PortalMinimalPerf.default | 87 | 84 | 1.04:1 |
RadioGroupMinimalPerf.default | 264 | 253 | 1.04:1 |
TextAreaMinimalPerf.default | 292 | 280 | 1.04:1 |
DropdownMinimalPerf.default | 1447 | 1409 | 1.03:1 |
HeaderSlotsPerf.default | 468 | 454 | 1.03:1 |
ItemLayoutMinimalPerf.default | 718 | 696 | 1.03:1 |
MenuMinimalPerf.default | 516 | 501 | 1.03:1 |
TooltipMinimalPerf.default | 1259 | 1227 | 1.03:1 |
CheckboxMinimalPerf.default | 1151 | 1126 | 1.02:1 |
DialogMinimalPerf.default | 452 | 445 | 1.02:1 |
ListCommonPerf.default | 402 | 393 | 1.02:1 |
MenuButtonMinimalPerf.default | 971 | 951 | 1.02:1 |
PopupMinimalPerf.default | 355 | 349 | 1.02:1 |
RefMinimalPerf.default | 112 | 110 | 1.02:1 |
TableMinimalPerf.default | 237 | 233 | 1.02:1 |
RosterPerf.default | 1559 | 1540 | 1.01:1 |
SegmentMinimalPerf.default | 200 | 198 | 1.01:1 |
ChatMinimalPerf.default | 441 | 441 | 1:1 |
ImageMinimalPerf.default | 228 | 228 | 1:1 |
ListMinimalPerf.default | 307 | 307 | 1:1 |
ProviderMergeThemesPerf.default | 655 | 655 | 1:1 |
SplitButtonMinimalPerf.default | 2281 | 2278 | 1:1 |
CustomToolbarPrototype.default | 1483 | 1486 | 1:1 |
TreeMinimalPerf.default | 479 | 480 | 1:1 |
ChatWithPopoverPerf.default | 200 | 202 | 0.99:1 |
EmbedMinimalPerf.default | 1904 | 1916 | 0.99:1 |
LoaderMinimalPerf.default | 183 | 184 | 0.99:1 |
TableManyItemsPerf.default | 1113 | 1125 | 0.99:1 |
ButtonOverridesMissPerf.default | 649 | 664 | 0.98:1 |
FormMinimalPerf.default | 231 | 235 | 0.98:1 |
SliderMinimalPerf.default | 738 | 751 | 0.98:1 |
StatusMinimalPerf.default | 382 | 388 | 0.98:1 |
ToolbarMinimalPerf.default | 526 | 535 | 0.98:1 |
BoxMinimalPerf.default | 194 | 199 | 0.97:1 |
DatepickerMinimalPerf.default | 3615 | 3737 | 0.97:1 |
GridMinimalPerf.default | 186 | 192 | 0.97:1 |
HeaderMinimalPerf.default | 193 | 200 | 0.97:1 |
ListNestedPerf.default | 315 | 324 | 0.97:1 |
ListWith60ListItems.default | 353 | 365 | 0.97:1 |
IconMinimalPerf.default | 402 | 416 | 0.97:1 |
VideoMinimalPerf.default | 423 | 435 | 0.97:1 |
FlexMinimalPerf.default | 147 | 155 | 0.95:1 |
InputMinimalPerf.default | 543 | 570 | 0.95:1 |
TextMinimalPerf.default | 191 | 201 | 0.95:1 |
AccordionMinimalPerf.default | 82 | 89 | 0.92:1 |
ChatDuplicateMessagesPerf.default | 146 | 158 | 0.92:1 |
📊 Bundle size report
Unchanged fixtures
|
fabricteam
reviewed
Sep 20, 2024
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
BaseButton | mount | 644 | 628 | 5000 | |
Breadcrumb | mount | 1683 | 1684 | 1000 | |
Checkbox | mount | 1694 | 1730 | 5000 | |
CheckboxBase | mount | 1488 | 1480 | 5000 | |
ChoiceGroup | mount | 3041 | 2953 | 5000 | |
ComboBox | mount | 702 | 692 | 1000 | |
CommandBar | mount | 6545 | 6524 | 1000 | |
ContextualMenu | mount | 11599 | 11970 | 1000 | |
DefaultButton | mount | 784 | 830 | 5000 | |
DetailsRow | mount | 2221 | 2185 | 5000 | |
DetailsRowFast | mount | 2239 | 2205 | 5000 | |
DetailsRowNoStyles | mount | 2049 | 2046 | 5000 | |
Dialog | mount | 2671 | 2804 | 1000 | |
DocumentCardTitle | mount | 228 | 227 | 1000 | |
Dropdown | mount | 2025 | 2024 | 5000 | |
FocusTrapZone | mount | 1164 | 1146 | 5000 | |
FocusZone | mount | 1120 | 1068 | 5000 | |
GroupedList | mount | 42344 | 42694 | 2 | |
GroupedList | virtual-rerender | 20430 | 20306 | 2 | |
GroupedList | virtual-rerender-with-unmount | 51807 | 51936 | 2 | |
GroupedListV2 | mount | 231 | 227 | 2 | |
GroupedListV2 | virtual-rerender | 212 | 219 | 2 | |
GroupedListV2 | virtual-rerender-with-unmount | 230 | 230 | 2 | |
IconButton | mount | 1124 | 1156 | 5000 | |
Label | mount | 344 | 340 | 5000 | |
Layer | mount | 2728 | 2762 | 5000 | |
Link | mount | 397 | 391 | 5000 | |
MenuButton | mount | 991 | 992 | 5000 | |
MessageBar | mount | 21462 | 21739 | 5000 | |
Nav | mount | 2038 | 2078 | 1000 | |
OverflowSet | mount | 776 | 801 | 5000 | |
Panel | mount | 1879 | 1823 | 1000 | |
Persona | mount | 746 | 751 | 1000 | |
Pivot | mount | 916 | 915 | 1000 | |
PrimaryButton | mount | 944 | 941 | 5000 | |
Rating | mount | 4730 | 4720 | 5000 | |
SearchBox | mount | 949 | 949 | 5000 | |
Shimmer | mount | 1898 | 1920 | 5000 | |
Slider | mount | 1322 | 1358 | 5000 | |
SpinButton | mount | 2960 | 3034 | 5000 | |
Spinner | mount | 384 | 388 | 5000 | |
SplitButton | mount | 1907 | 1850 | 5000 | |
Stack | mount | 427 | 423 | 5000 | |
StackWithIntrinsicChildren | mount | 893 | 865 | 5000 | |
StackWithTextChildren | mount | 2812 | 2790 | 5000 | |
SwatchColorPicker | mount | 6429 | 6367 | 5000 | |
TagPicker | mount | 1483 | 1468 | 5000 | |
Text | mount | 385 | 390 | 5000 | |
TextField | mount | 954 | 960 | 5000 | |
ThemeProvider | mount | 866 | 851 | 5000 | |
ThemeProvider | virtual-rerender | 591 | 578 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1288 | 1293 | 5000 | |
Toggle | mount | 621 | 611 | 5000 | |
buttonNative | mount | 187 | 190 | 5000 |
Mitch-At-Work
force-pushed
the
user/mifraser/stable-carousel
branch
from
September 27, 2024 19:54
f8e965a
to
4943e28
Compare
Mitch-At-Work
requested review from
a team,
JustSlone,
jurokapsiar and
tudorpopams
as code owners
September 27, 2024 22:03
Mitch-At-Work
force-pushed
the
user/mifraser/stable-carousel
branch
from
October 1, 2024 16:00
d7084fe
to
f400380
Compare
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
JustSlone
approved these changes
Oct 1, 2024
mltejera
approved these changes
Oct 1, 2024
Hotell
reviewed
Oct 2, 2024
Hotell
reviewed
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V9 react-carousel stable release.
Previous Behavior
Carousel in preview
New Behavior
Carousel in release
Related Issue(s)