Create v9 version of chart controls #32966
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Anush <[email protected]>
Co-authored-by: Anush <[email protected]>
…luentui into usr/atisjai/chartsV9
…luentui into usr/atisjai/chartsV9
📊 Bundle size report✅ No changes found |
fabricteam
reviewed
Oct 2, 2024
| @@ -376,6 +376,8 @@ packages/react-components/react-color-picker-preview/library @microsoft/cxe-prg | |||
| packages/react-components/react-color-picker-preview/stories @microsoft/cxe-prg | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv9 Visual Regression Report
Avatar Converged 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar Converged.Badge Mask RTL.chromium.png | 6 | Changed |
| Avatar Converged.badgeMask.chromium.png | 6 | Changed |
| Avatar Converged.size+inactive+badge.chromium.png | 1 | Changed |
Drawer 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Drawer.Full Overlay High Contrast.chromium.png | 2244 | Changed |
react-charts-preview-DonutChart 6 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charts-preview-DonutChart.Basic Dark Mode.chromium.png | 0 | Added |
| react-charts-preview-DonutChart.Basic RTL.chromium.png | 0 | Added |
| react-charts-preview-DonutChart.Basic.chromium.png | 0 | Added |
| react-charts-preview-DonutChart.Dynamic Dark Mode.chromium.png | 0 | Added |
| react-charts-preview-DonutChart.Dynamic RTL.chromium.png | 0 | Added |
| react-charts-preview-DonutChart.Dynamic.chromium.png | 0 | Added |
react-charts-preview-HorizontalBarChart 9 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charts-preview-HorizontalBarChart.Basic Dark Mode.chromium.png | 0 | Added |
| react-charts-preview-HorizontalBarChart.Basic RTL.chromium.png | 0 | Added |
| react-charts-preview-HorizontalBarChart.Basic.chromium.png | 0 | Added |
| react-charts-preview-HorizontalBarChart.Variant Dark Mode.chromium.png | 0 | Added |
| react-charts-preview-HorizontalBarChart.Variant RTL.chromium.png | 0 | Added |
| react-charts-preview-HorizontalBarChart.Variant.chromium.png | 0 | Added |
| react-charts-preview-HorizontalBarChart.With Benchmark Dark Mode.chromium.png | 0 | Added |
| react-charts-preview-HorizontalBarChart.With Benchmark RTL.chromium.png | 0 | Added |
| react-charts-preview-HorizontalBarChart.With_Benchmark.chromium.png | 0 | Added |
react-charts-preview-Legend 6 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charts-preview-Legend.Basic Dark Mode.chromium.png | 0 | Added |
| react-charts-preview-Legend.Basic RTL.chromium.png | 0 | Added |
| react-charts-preview-Legend.Basic.chromium.png | 0 | Added |
| react-charts-preview-Legend.Overflow Dark Mode.chromium.png | 0 | Added |
| react-charts-preview-Legend.Overflow RTL.chromium.png | 0 | Added |
| react-charts-preview-Legend.Overflow.chromium.png | 0 | Added |
react-charts-preview-LineChart 12 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charts-preview-LineChart.Basic Dark Mode.chromium.png | 0 | Added |
| react-charts-preview-LineChart.Basic RTL.chromium.png | 0 | Added |
| react-charts-preview-LineChart.Basic.chromium.png | 0 | Added |
| react-charts-preview-LineChart.Events Dark Mode.chromium.png | 0 | Added |
| react-charts-preview-LineChart.Events RTL.chromium.png | 0 | Added |
| react-charts-preview-LineChart.Events.chromium.png | 0 | Added |
| react-charts-preview-LineChart.Gaps Dark Mode.chromium.png | 0 | Added |
| react-charts-preview-LineChart.Gaps RTL.chromium.png | 0 | Added |
| react-charts-preview-LineChart.Gaps.chromium.png | 0 | Added |
| react-charts-preview-LineChart.Multiple Dark Mode.chromium.png | 0 | Added |
| react-charts-preview-LineChart.Multiple RTL.chromium.png | 0 | Added |
| react-charts-preview-LineChart.Multiple.chromium.png | 0 | Added |
react-charts-preview-SparkLineChart 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charts-preview-SparkLineChart.Basic Dark Mode.chromium.png | 0 | Added |
| react-charts-preview-SparkLineChart.Basic RTL.chromium.png | 0 | Added |
| react-charts-preview-SparkLineChart.Basic.chromium.png | 0 | Added |
react-charts-preview-VerticalBarChart 12 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charts-preview-VerticalBarChart.Basic - Secondary Y Axis.chromium.png | 0 | Added |
| react-charts-preview-VerticalBarChart.Basic Secondary Y Axis Dark Mode.chromium.png | 0 | Added |
| react-charts-preview-VerticalBarChart.Basic Secondary Y Axis RTL.chromium.png | 0 | Added |
| react-charts-preview-VerticalBarChart.Date Axis Vbc Dark Mode.chromium.png | 0 | Added |
| react-charts-preview-VerticalBarChart.Date Axis Vbc RTL.chromium.png | 0 | Added |
| react-charts-preview-VerticalBarChart.Date Axis- VBC.chromium.png | 0 | Added |
| react-charts-preview-VerticalBarChart.Dynamic - Wrap Labels.chromium.png | 0 | Added |
| react-charts-preview-VerticalBarChart.Dynamic Wrap Labels Dark Mode.chromium.png | 0 | Added |
| react-charts-preview-VerticalBarChart.Dynamic Wrap Labels RTL.chromium.png | 0 | Added |
| react-charts-preview-VerticalBarChart.Rotated Label Hide Legends Dark Mode.chromium.png | 0 | Added |
| react-charts-preview-VerticalBarChart.Rotated Label Hide Legends RTL.chromium.png | 0 | Added |
| react-charts-preview-VerticalBarChart.Rotated Label- Hide Legends.chromium.png | 0 | Added |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 598 | 631 | 5000 | |
| Breadcrumb | mount | 1694 | 1702 | 1000 | |
| Checkbox | mount | 1718 | 1710 | 5000 | |
| CheckboxBase | mount | 1479 | 1507 | 5000 | |
| ChoiceGroup | mount | 2983 | 3038 | 5000 | |
| ComboBox | mount | 699 | 686 | 1000 | |
| CommandBar | mount | 6561 | 6627 | 1000 | |
| ContextualMenu | mount | 13339 | 13109 | 1000 | |
| DefaultButton | mount | 799 | 808 | 5000 | |
| DetailsRow | mount | 2213 | 2270 | 5000 | |
| DetailsRowFast | mount | 2231 | 2226 | 5000 | |
| DetailsRowNoStyles | mount | 2062 | 2032 | 5000 | |
| Dialog | mount | 2712 | 2772 | 1000 | |
| DocumentCardTitle | mount | 227 | 230 | 1000 | |
| Dropdown | mount | 2014 | 2004 | 5000 | |
| FocusTrapZone | mount | 1150 | 1160 | 5000 | |
| FocusZone | mount | 1108 | 1098 | 5000 | |
| GroupedList | mount | 42131 | 42540 | 2 | |
| GroupedList | virtual-rerender | 20324 | 20461 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 52046 | 51902 | 2 | |
| GroupedListV2 | mount | 227 | 235 | 2 | |
| GroupedListV2 | virtual-rerender | 226 | 218 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 245 | 226 | 2 | |
| IconButton | mount | 1165 | 1152 | 5000 | |
| Label | mount | 347 | 345 | 5000 | |
| Layer | mount | 2739 | 2824 | 5000 | |
| Link | mount | 396 | 397 | 5000 | |
| MenuButton | mount | 995 | 997 | 5000 | |
| MessageBar | mount | 21564 | 21536 | 5000 | |
| Nav | mount | 2086 | 2075 | 1000 | |
| OverflowSet | mount | 804 | 797 | 5000 | |
| Panel | mount | 1883 | 1913 | 1000 | |
| Persona | mount | 765 | 774 | 1000 | |
| Pivot | mount | 896 | 910 | 1000 | |
| PrimaryButton | mount | 943 | 943 | 5000 | |
| Rating | mount | 4725 | 4732 | 5000 | |
| SearchBox | mount | 938 | 913 | 5000 | |
| Shimmer | mount | 1975 | 1939 | 5000 | |
| Slider | mount | 1353 | 1350 | 5000 | |
| SpinButton | mount | 3008 | 2953 | 5000 | |
| Spinner | mount | 390 | 392 | 5000 | |
| SplitButton | mount | 1935 | 1883 | 5000 | |
| Stack | mount | 431 | 432 | 5000 | |
| StackWithIntrinsicChildren | mount | 858 | 894 | 5000 | |
| StackWithTextChildren | mount | 2844 | 2819 | 5000 | |
| SwatchColorPicker | mount | 6448 | 6496 | 5000 | |
| TagPicker | mount | 1460 | 1473 | 5000 | |
| Text | mount | 381 | 395 | 5000 | |
| TextField | mount | 961 | 951 | 5000 | |
| ThemeProvider | mount | 875 | 876 | 5000 | |
| ThemeProvider | virtual-rerender | 586 | 590 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1323 | 1339 | 5000 | |
| Toggle | mount | 621 | 613 | 5000 | |
| buttonNative | mount | 193 | 201 | 5000 |
fabricteam
reviewed
Oct 4, 2024
| @@ -376,6 +376,8 @@ packages/react-components/react-color-picker-preview/library @microsoft/cxe-prg | |||
| packages/react-components/react-color-picker-preview/stories @microsoft/cxe-prg | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv8 Visual Regression Report
react-charting-LineChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-LineChart.Gaps.chromium.png | 1 | Changed |
react-charting-VerticalBarChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-VerticalBarChart.Basic - Secondary Y Axis.chromium.png | 4 | Changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Creating chart controls native for fluent v9.
These controls are a direct port from v8 with exact match for design and functionality.
Currently these controls are in compatibility mode. Constructs for slots will be added in future versions.
This PR includes 6 components - Line Chart, Horizontal Bar Chart, Vertical Bar Chart, Donut Chart, Legends and Sparkline.
Related Issue(s)