Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: useMergedTabsterAttributes should accept null/undefined values #32983

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: useMergedTabsterAttributes should accept null/undefined values #32983

wants to merge 2 commits into from

Conversation

ling1726
Copy link
Member

@ling1726 ling1726 commented Oct 4, 2024

Updates the signature of useMergedTabsterAttributes to accept null/undefined values and ignores them in the merging process

@ling1726
fix: useMergedTabsterAttributes should accept null/undefined values
ebfbfb5 
Updates the signature of `useMergedTabsterAttributes` to accept
null/undefined values and ignores them in the merging process
@ling1726 ling1726 marked this pull request as ready for review October 4, 2024 12:30
@ling1726 ling1726 requested a review from a team as a code owner October 4, 2024 12:30
@github-actions github-actions bot added this to the October Project Cycle Q4 2024 milestone Oct 4, 2024
@fabricteam
Copy link
Collaborator

fabricteam commented Oct 4, 2024 •
edited
Loading

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: entire library		 1.101 MB
272.228 kB		 1.101 MB
272.24 kB		 17 B
12 B
react-list-preview
ListItem		 112.69 kB
33.425 kB		 112.707 kB
33.432 kB		 17 B
7 B
react-table
DataGrid		 160.985 kB
45.678 kB		 161.002 kB
45.689 kB		 17 B
11 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-accordion
Accordion (including children components)		 105.051 kB
32.257 kB
react-avatar
Avatar		 49.303 kB
15.815 kB
react-avatar
AvatarGroup		 20.106 kB
7.968 kB
react-avatar
AvatarGroupItem		 63.447 kB
20.034 kB
react-breadcrumb
@fluentui/react-breadcrumb - package		 114.221 kB
31.654 kB
react-button
Button		 37.104 kB
10.766 kB
react-button
CompoundButton		 43.518 kB
12.068 kB
react-button
MenuButton		 41.919 kB
12.108 kB
react-button
SplitButton		 49.936 kB
13.681 kB
react-button
ToggleButton		 53.037 kB
12.528 kB
react-calendar-compat
Calendar Compat		 150.095 kB
40.026 kB
react-card
Card - All		 101.77 kB
28.772 kB
react-card
Card		 94.544 kB
26.951 kB
react-card
CardFooter		 14.355 kB
5.79 kB
react-card
CardHeader		 16.888 kB
6.669 kB
react-card
CardPreview		 14.42 kB
5.922 kB
react-checkbox
Checkbox		 35.118 kB
12.077 kB
react-combobox
Combobox (including child components)		 104.398 kB
34.199 kB
react-combobox
Dropdown (including child components)		 105.011 kB
34.125 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 69.14 kB
20.137 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 218.842 kB
63.382 kB
react-components
react-components: FluentProvider & webLightTheme		 44.447 kB
14.59 kB
react-datepicker-compat
DatePicker Compat		 224.165 kB
63.423 kB
react-dialog
Dialog (including children components)		 100.247 kB
30.042 kB
react-field
Field		 23.384 kB
8.891 kB
react-input
Input		 28.014 kB
9.444 kB
react-link
Link		 17.326 kB
7.032 kB
react-list-preview
List		 89.148 kB
26.597 kB
react-menu
Menu (including children components)		 152.534 kB
46.049 kB
react-menu
Menu (including selectable components)		 155.215 kB
46.53 kB
react-message-bar
MessageBar (all components)		 24.85 kB
9.256 kB
react-overflow
hooks only		 12.808 kB
4.819 kB
react-persona
Persona		 56.194 kB
17.695 kB
react-popover
Popover		 128.854 kB
40.286 kB
react-portal
Portal		 14.563 kB
5.118 kB
react-portal-compat
PortalCompatProvider		 8.39 kB
2.64 kB
react-progress
ProgressBar		 17.084 kB
6.891 kB
react-provider
FluentProvider		 24.623 kB
8.893 kB
react-radio
Radio		 32.672 kB
10.343 kB
react-radio
RadioGroup		 15.762 kB
6.423 kB
react-select
Select		 27.732 kB
10.124 kB
react-slider
Slider		 37.169 kB
12.538 kB
react-spinbutton
SpinButton		 36.06 kB
11.815 kB
react-swatch-picker
@fluentui/react-swatch-picker - package		 104.258 kB
30.231 kB
react-switch
Switch		 35.319 kB
11.314 kB
react-table
Table (Primitives only)		 42.643 kB
13.82 kB
react-table
Table as DataGrid		 131.837 kB
36.531 kB
react-table
Table (Selection only)		 70.504 kB
19.962 kB
react-table
Table (Sort only)		 69.147 kB
19.574 kB
react-tag-picker
@fluentui/react-tag-picker - package		 184.106 kB
55.428 kB
react-tags
InteractionTag		 15.199 kB
6.157 kB
react-tags
Tag		 29.016 kB
9.524 kB
react-tags
TagGroup		 82.719 kB
24.524 kB
react-textarea
Textarea		 26.572 kB
9.755 kB
react-timepicker-compat
TimePicker		 107.387 kB
35.758 kB
react-toast
Toast (including Toaster)		 98.338 kB
29.591 kB
react-tooltip
Tooltip		 55.517 kB
19.515 kB
🤖 This report was generated against 972683d49b56e0f0009c8c82f7c7e04ac589ee74

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 4, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender 33 35 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 612 641 5000
Button mount 314 310 5000
Field mount 1138 1129 5000
FluentProvider mount 709 735 5000
FluentProviderWithTheme mount 84 79 10
FluentProviderWithTheme virtual-rerender 33 35 10 Possible regression
FluentProviderWithTheme virtual-rerender-with-unmount 75 81 10
MakeStyles mount 882 881 50000
Persona mount 1879 1752 5000
SpinButton mount 1453 1442 5000
SwatchPicker mount 1685 1687 5000

fabricteam
fabricteam reviewed Oct 4, 2024
View reviewed changes
packages/react-components/react-tabster/etc/react-tabster.api.md
@@ -1486,7 +1486,7 @@ export function useFocusWithin<TElement extends HTMLElement = HTMLElement>(): Re
export function useKeyboardNavAttribute<E extends HTMLElement>(): RefObject<E>;
Copy link
Collaborator

@fabricteam fabricteam Oct 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentuiv9 Visual Regression Report

Avatar Converged 2 screenshots
Image Name Diff(in Pixels) Image Type
Avatar Converged.Badge Mask RTL.chromium.png 2 Changed
Avatar Converged.badgeMask.chromium.png 6 Changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
October Project Cycle Q4 2024
Development

Successfully merging this pull request may close these issues.
2 participants
@ling1726 @fabricteam