Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conversion sequences and describe ranks #168

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

llvm-beanz
Copy link
Collaborator

This change fixes a spec bug in the description of HLSL truncation casts, restricts the array-to-pointer cast to unbounded arrays (where they decay to pointers), and specifies integral and floating point conversion ranks.

This updates the spec to be more consistent with how the language is being implemented in clang and lays the groundwork for describing overload resolution rules.

This change fixes a spec bug in the description of HLSL truncation
casts, restricts the array-to-pointer cast to unbounded arrays (where
they decay to pointers), and specifies integral and floating point
conversion ranks.

This updates the spec to be more consistent with how the language is
being implemented in clang and lays the groundwork for describing
overload resolution rules.
@llvm-beanz
Copy link
Collaborator Author

PDF Link

Copy link
Collaborator

@coopp coopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I read through a few times and I can understand it!

Copy link
Collaborator

@bharadwajy bharadwajy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a couple of suggested changes.

specs/language/conversions.tex Outdated Show resolved Hide resolved
specs/language/conversions.tex Outdated Show resolved Hide resolved
llvm-beanz and others added 2 commits April 8, 2024 18:20
Co-authored-by: S. Bharadwaj Yadavalli <[email protected]>
Co-authored-by: S. Bharadwaj Yadavalli <[email protected]>
@llvm-beanz llvm-beanz merged commit 35640cf into microsoft:main Apr 15, 2024
3 checks passed
@llvm-beanz llvm-beanz deleted the cbieneman/conversions-take2 branch April 15, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants