-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update conversion sequences and describe ranks #168
Merged
llvm-beanz
merged 3 commits into
microsoft:main
from
llvm-beanz:cbieneman/conversions-take2
Apr 15, 2024
Merged
Update conversion sequences and describe ranks #168
llvm-beanz
merged 3 commits into
microsoft:main
from
llvm-beanz:cbieneman/conversions-take2
Apr 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes a spec bug in the description of HLSL truncation casts, restricts the array-to-pointer cast to unbounded arrays (where they decay to pointers), and specifies integral and floating point conversion ranks. This updates the spec to be more consistent with how the language is being implemented in clang and lays the groundwork for describing overload resolution rules.
bogner
approved these changes
Mar 26, 2024
coopp
reviewed
Apr 8, 2024
coopp
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I read through a few times and I can understand it!
bharadwajy
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a couple of suggested changes.
Co-authored-by: S. Bharadwaj Yadavalli <[email protected]>
Co-authored-by: S. Bharadwaj Yadavalli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a spec bug in the description of HLSL truncation casts, restricts the array-to-pointer cast to unbounded arrays (where they decay to pointers), and specifies integral and floating point conversion ranks.
This updates the spec to be more consistent with how the language is being implemented in clang and lays the groundwork for describing overload resolution rules.