Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

igvm_defs: add support for specific purpose memory in MemoryMapEntryType. #64

Merged

Conversation

Patrick-Payne
Copy link
Contributor

@Patrick-Payne Patrick-Payne commented Jun 5, 2024

This PR adds a MemoryMapEntryType for specific purpose memory. This corresponds with the UEFI memory map attribute EFI_MEMORY_SP, added in UEFI 2.8. EFI_MEMORY_SP is used to indicate that the memory has special properties and is to be reserved for application use, and shouldn't be used by the firmware or OS.

@Patrick-Payne Patrick-Payne requested a review from a team as a code owner June 5, 2024 17:30
igvm_defs/src/lib.rs Outdated Show resolved Hide resolved
@chris-oo
Copy link
Member

chris-oo commented Jun 5, 2024

Please retitle your pr to something like igvm_defs: add support for special purpose memory in MemoryMapEntryType.

@Patrick-Payne Patrick-Payne changed the title Update MemoryMapEntryType to add a value for special purpose memory. igvm_defs: add support for special purpose memory in MemoryMapEntryType. Jun 5, 2024
@chris-oo
Copy link
Member

chris-oo commented Jun 5, 2024

I think unfortunately your PR is gated on #63 being resolved, but hopefully that should be fixed soon.

@Patrick-Payne Patrick-Payne changed the title igvm_defs: add support for special purpose memory in MemoryMapEntryType. igvm_defs: add support for specific purpose memory in MemoryMapEntryType. Jun 14, 2024
@Patrick-Payne Patrick-Payne force-pushed the user/patpa/special-purpose-memory branch from b1ac0fc to 9eec1a0 Compare June 18, 2024 22:38
@Patrick-Payne Patrick-Payne force-pushed the user/patpa/special-purpose-memory branch from 9eec1a0 to 40c831e Compare June 21, 2024 22:32
@chris-oo chris-oo merged commit 553a654 into microsoft:main Jun 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants